Summary: | Move MathMLOperatorDictionary features into a separate module | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||
Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alex, jfernandez | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 152244, 159619 | ||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2015-12-14 01:28:17 PST
Created attachment 267287 [details]
Patch
Comment on attachment 267287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267287&action=review Looks fine to me, though I do have a few nits about the coding style. > Source/WebCore/rendering/mathml/MathMLOperatorDictionary.cpp:1105 > + if (entry != dictionary && (entry-1)->character == textContent) > + entry--; > + if (entry != dictionary && (entry-1)->character == textContent) > + entry--; The binary operators should have spaces around them, thus: "entry - 1" > Source/WebCore/rendering/mathml/MathMLOperatorDictionary.cpp:1113 > + return !(tryBinarySearch<const UChar, UChar>(horizontalOperators, WTF_ARRAY_LENGTH(horizontalOperators), textContent, ExtractKeyHorizontal)); Is the outermost pair of parenthesis necessary here? If not, might be better to remove it. Committed r194031: <http://trac.webkit.org/changeset/194031> |