Bug 152180

Summary: Improve Animometer on iOS
Product: WebKit Reporter: Jon Lee <jonlee>
Component: AnimationsAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jon Lee 2015-12-11 11:34:28 PST
Style the benchmark to look better on iOS
Comment 1 Radar WebKit Bug Importer 2015-12-11 11:34:46 PST
<rdar://problem/23862108>
Comment 2 Jon Lee 2015-12-11 12:05:09 PST
Created attachment 267182 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-12-11 13:01:18 PST
Comment on attachment 267182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267182&action=review

> PerformanceTests/Animometer/runner/animometer.html:4
> +    <meta name="viewport" content="width=device-width, user-scalable=no">

user-scalable=no" is to avoid running while scaled? Would prefer to avoid disabling of scaling.
Comment 4 Jon Lee 2015-12-11 13:02:39 PST
(In reply to comment #3)
> Comment on attachment 267182 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267182&action=review
> 
> > PerformanceTests/Animometer/runner/animometer.html:4
> > +    <meta name="viewport" content="width=device-width, user-scalable=no">
> 
> user-scalable=no" is to avoid running while scaled? Would prefer to avoid
> disabling of scaling.

I could look into doing this dynamically.
Comment 5 Simon Fraser (smfr) 2015-12-11 13:14:54 PST
> I could look into doing this dynamically.

Probably not worth the effort.
Comment 6 WebKit Commit Bot 2015-12-11 13:47:53 PST
Comment on attachment 267182 [details]
Patch

Clearing flags on attachment: 267182

Committed r193975: <http://trac.webkit.org/changeset/193975>
Comment 7 WebKit Commit Bot 2015-12-11 13:47:58 PST
All reviewed patches have been landed.  Closing bug.