| Summary: | Modern IDB: Updates to 3 intversion tests, and/or their results | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
| Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, alecflett, commit-queue, jsbell | ||||||||
| Priority: | P2 | ||||||||||
| Version: | Safari 9 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 149117, 150882 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Brady Eidson
2015-12-11 10:50:19 PST
Created attachment 267174 [details]
Patch v1
Created attachment 267175 [details]
Patch v2
This might not apply to trunk because it relies on patches from 152175 and 152177 It's still correct and reviewable. Comment on attachment 267175 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=267175&action=review > LayoutTests/platform/wk2/storage/indexeddb/intversion-close-in-oncomplete-expected.txt:24 > -PASS event.target.result is null > +FAIL event.target.result should be undefined. Was null What's this? Created attachment 267180 [details]
Patch v3
(In reply to comment #4) > Comment on attachment 267175 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267175&action=review > > > LayoutTests/platform/wk2/storage/indexeddb/intversion-close-in-oncomplete-expected.txt:24 > > -PASS event.target.result is null > > +FAIL event.target.result should be undefined. Was null > > What's this? As we went over in person - WK2 (Legacy IDB) is known to get this wrong, so it is "correct" for WK2 to output a "FAIL" here. Comment on attachment 267180 [details] Patch v3 Clearing flags on attachment: 267180 Committed r193980: <http://trac.webkit.org/changeset/193980> All reviewed patches have been landed. Closing bug. |