Bug 152166

Summary: [JSC] Little cleanup of FTLOutput type casts and conversions
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, ggaren, keith_miller, mark.lam, msaboff, rniwa, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews107 for mac-yosemite-wk2
none
Archive of layout-test-results from ews112 for mac-yosemite
none
Patch none

Description Benjamin Poulain 2015-12-10 21:11:42 PST
[JSC] Little cleanup of FTLOutput type casts and conversions
Comment 1 Benjamin Poulain 2015-12-10 21:14:52 PST
Created attachment 267161 [details]
Patch
Comment 2 Geoffrey Garen 2015-12-10 21:54:35 PST
Comment on attachment 267161 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2015-12-10 21:55:13 PST
Hmmm... maybe there's a bug?

  webaudio/audiobuffersource-multi-channels.html [ Crash ]
  webaudio/audiobuffersource-playbackState.html [ Crash ]
  webaudio/audiobuffersource-playbackrate.html [ Crash ]
  webaudio/audiobuffersource.html [ Crash ]
  webaudio/convolver-setBuffer-different-samplerate.html [ Crash ]
  webaudio/mixing.html [ Crash ]
  webaudio/oscillator-custom.html [ Crash ]
  webaudio/oscillator-sawtooth.html [ Crash ]
  webaudio/oscillator-sine.html [ Crash ]
  webaudio/oscillator-square.html [ Crash ]
  webaudio/oscillator-triangle.html [ Crash ]
  webaudio/test-basic.html [ Crash ]
  webaudio/up-mixing-mono-51.html [ Crash ]
  webaudio/up-mixing-stereo-51.html [ Crash ]
  webaudio/waveshaper.html [ Crash ]
Comment 4 Build Bot 2015-12-10 22:16:27 PST
Comment on attachment 267161 [details]
Patch

Attachment 267161 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/543808

New failing tests:
webaudio/oscillator-square.html
webaudio/up-mixing-stereo-51.html
webaudio/mixing.html
webaudio/oscillator-sine.html
webaudio/waveshaper.html
webaudio/oscillator-custom.html
webaudio/audiobuffersource-playbackState.html
webaudio/up-mixing-mono-51.html
webaudio/audiobuffersource-multi-channels.html
webaudio/audiobuffersource-playbackrate.html
webaudio/audiobuffersource.html
webaudio/convolver-setBuffer-different-samplerate.html
webaudio/test-basic.html
webaudio/oscillator-triangle.html
webaudio/oscillator-sawtooth.html
Comment 5 Build Bot 2015-12-10 22:16:31 PST
Created attachment 267162 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2015-12-10 22:26:07 PST
Comment on attachment 267161 [details]
Patch

Attachment 267161 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/543847

New failing tests:
webaudio/oscillator-square.html
webaudio/up-mixing-stereo-51.html
webaudio/mixing.html
webaudio/oscillator-sine.html
webaudio/oscillator-custom.html
webaudio/gain.html
webaudio/up-mixing-mono-51.html
webaudio/audiobuffersource-playbackState.html
webaudio/audiobuffersource-multi-channels.html
webaudio/audiobuffersource-playbackrate.html
webaudio/audiobuffersource.html
webaudio/test-basic.html
webaudio/oscillator-triangle.html
webaudio/oscillator-sawtooth.html
Comment 7 Build Bot 2015-12-10 22:26:10 PST
Created attachment 267163 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Benjamin Poulain 2015-12-11 00:16:53 PST
Created attachment 267165 [details]
Patch
Comment 9 WebKit Commit Bot 2015-12-11 09:16:21 PST
Comment on attachment 267165 [details]
Patch

Clearing flags on attachment: 267165

Committed r193955: <http://trac.webkit.org/changeset/193955>
Comment 10 WebKit Commit Bot 2015-12-11 09:16:25 PST
All reviewed patches have been landed.  Closing bug.