Bug 152145

Summary:

[Win] Support building under Cygwin or native Perl

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Tools / Tests

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, ddkilzer, lforschler

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

OS:

All

Attachments:

Description	Flags
Patch	ddkilzer: review+

Brent Fulgham

Reported 2015-12-10 10:05:46 PST

We can get build failures if a DOS instance is used to drive a build from Cygwin Perl because the "auto-version.pl" script attempts to apply abs_path to the DOS path, resulting in an invalid mixture of DOS and UNIX paths. Instead, when we are running under Cygwin we should make sure the root path we use is in the correct UNIX form.

Attachments
Patch (1.44 KB, patch) 2015-12-10 10:14 PST, Brent Fulgham	ddkilzer: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2015-12-10 10:07:52 PST

<rdar://problem/23839868>

Brent Fulgham

Comment 2 2015-12-10 10:14:43 PST

Created attachment 267113 [details] Patch

David Kilzer (:ddkilzer)

Comment 3 2015-12-10 10:28:11 PST

Comment on attachment 267113 [details] Patch r=me. Too bad this isn't very testable (since the test would only work on cygwin) since we have some autoversion.pl tests in Tools/Scripts/webkitperl/auto-version_unittest/.

Brent Fulgham

Comment 4 2015-12-10 17:21:48 PST

Committed r193935: <http://trac.webkit.org/changeset/193935>

Note You need to log in before you can comment on or make changes to this bug.