Bug 152118

Summary: [TexMap] Operate with a reference to the TextureMapper wherever possible
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2015-12-10 03:45:16 PST
[TexMap] Operate with a reference to the TextureMapper wherever possible
Attachments
Patch (65.33 KB, patch)
2015-12-10 03:51 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (65.25 KB, patch)
2015-12-15 01:50 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2015-12-10 03:51:48 PST
Created attachment 267090 [details] Patch Will first run it through the EWS.
Martin Robinson
Comment 2 2015-12-10 04:15:37 PST
Comment on attachment 267090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267090&action=review r=me when this passes the EWS. > Source/WebCore/ChangeLog:10 > + TextureMapperLayer member variable which is null until the TextureMapper object Perhaps you could use Optional<TextureMapper&> in this case? > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:81 > + TextureMapperPaintOptions options(*m_textureMapper); Probably should do ASSERT(m_textureMapper) here.
Martin Robinson
Comment 3 2015-12-14 08:12:55 PST
Comment on attachment 267090 [details] Patch Looks like it passed just fine through the EWS.
Zan Dobersek
Comment 4 2015-12-15 01:06:40 PST
Comment on attachment 267090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267090&action=review >> Source/WebCore/ChangeLog:10 >> + TextureMapperLayer member variable which is null until the TextureMapper object > > Perhaps you could use Optional<TextureMapper&> in this case? Let's try that. >> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:81 >> + TextureMapperPaintOptions options(*m_textureMapper); > > Probably should do ASSERT(m_textureMapper) here. OK.
Zan Dobersek
Comment 5 2015-12-15 01:33:35 PST
Comment on attachment 267090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267090&action=review >>> Source/WebCore/ChangeLog:10 >>> + TextureMapperLayer member variable which is null until the TextureMapper object >> >> Perhaps you could use Optional<TextureMapper&> in this case? > > Let's try that. Optional<> doesn't work for references, and the ownership of the TextureMapper object should be kept in LayerTreeHost/CoordinatedGraphicsScene, so this isn't possible.
Zan Dobersek
Comment 6 2015-12-15 01:50:09 PST
Created attachment 267353 [details] Patch for landing
Zan Dobersek
Comment 7 2015-12-15 03:54:39 PST
Comment on attachment 267353 [details] Patch for landing Clearing flags on attachment: 267353 Committed r194103: <http://trac.webkit.org/changeset/194103>
Zan Dobersek
Comment 8 2015-12-15 03:54:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.