Bug 152104

Summary: TextPainter: Make before and after selection painting more explicit.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, mmaxfield, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mmaxfield: review+

alan
Reported 2015-12-09 19:40:46 PST
Instead of swapping start and end positions, we should call 0-startPosition and endPosition-length drawText calls.
Attachments
Patch (6.96 KB, patch)
2015-12-09 19:54 PST, alan 		mmaxfield: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2015-12-09 19:54:38 PST
Created attachment 267068 [details] Patch
Myles C. Maxfield
Comment 2 2015-12-09 20:48:36 PST
Comment on attachment 267068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267068&action=review > Source/WebCore/rendering/TextPainter.cpp:172 > // For stroked painting, we have to change the text drawing mode. It's probably dangerous to leave that mutated as a side Comment should probably go above the GraphicsContextStateSaver. > Source/WebCore/rendering/TextPainter.cpp:184 > // paint only the text that is selected Period makes it a sentence.
alan
Comment 3 2015-12-09 21:00:18 PST
Committed r193891: <http://trac.webkit.org/changeset/193891>
Note You need to log in before you can comment on or make changes to this bug.