Bug 15206
| Summary: | REGRESSION: links/images cut in half (body:last-child CSS hack doesn't work in TOT) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Carson <dacarson> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bdakin, cgriego, hyatt, mitz, vicki |
| Priority: | P1 | Keywords: | InRadar, Regression |
| Version: | 523.x (Safari 3) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
| URL: | http://sfgate.com | ||
| Bug Depends on: | 4812 | ||
| Bug Blocks: | |||
David Carson
The images in the left hand side of the screen, in the Marketplace section have the bottom half cut off.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
mitz
This bug stems from the recent removal of (buggy) :last-child support. Specifically, WebKit no longer applies this odd rule[1] in <http://sfgate.com/templates/types/homepage/style/homepage.css>:
body:last-child #verticalmenu li a {
width:auto;
display:block;
}
[1] body:last-child is a CSS hack for targeting specific browsers: <http://thomas.tanreisoftware.com/?p=11>.
Bug 5468 is tracking the :last-child situation.
mitz
Andrew Wellington has confirmed that this is indeed a regression from Safari 2.0.4 (which had the buggy :last-child support).
To keep the CSS hack working, WebKit could special-case body:last-child. Doing so would be backwards- and forwards-compatible.
Otherwise, I am afraid this bug is an evangelism bug.
David Kilzer (:ddkilzer)
<rdar://problem/5488787>
Beth Dakin
I talked to Hyatt about this on IRC. He didn't like the idea of a hack, so for now, we will make this an Evangelism bug.
mitz
:last-child fixed in <http://trac.webkit.org/projects/webkit/changeset/29933>.