Bug 152055

Summary: [TexMap] pixel coverage multiplication in TiledBackingStore can overflow
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, cmarcelo, commit-queue, kondapallykalyan, luiz, noam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Example of the problem none

Zan Dobersek
Reported 2015-12-09 03:54:04 PST
[TexMap] pixel coverage multiplication in TiledBackingStore can overflow
Attachments
Patch (2.52 KB, patch)
2015-12-09 03:58 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Example of the problem (56.76 KB, image/png)
2015-12-09 04:28 PST, Zan Dobersek 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2015-12-09 03:58:55 PST
Created attachment 266987 [details] Patch
Zan Dobersek
Comment 2 2015-12-09 04:28:22 PST
Created attachment 266991 [details] Example of the problem This shows the issue on the poster-circle demo, with tiles missing from different rings because the pixel coverage area overflowed. The problem isn't fixed until the next layer flush, and only if the tiles are not in such a position that would again result in overflowing the candidate area multiplication.
Zan Dobersek
Comment 3 2015-12-09 06:02:26 PST
(In reply to comment #2) > The problem isn't fixed until the next layer flush, and only if the tiles > are not in such a position that would again result in overflowing the > candidate area multiplication. It should be noted that on WebKitGTK+ there's at the moment an abundance of layer flushes (essentially for every frame when running animations), so the tiles are created soon after the animation starts and the layers move into a position that covers less area. The image of the problem is from the Wayland port which uses Coordinated Graphics for layer flushing (which is additionally optimized to be kept to a minimum).
Zan Dobersek
Comment 4 2015-12-09 06:04:34 PST
I also understand a test would be desired, but the only way to test for this would be to run the compositing tests and enable pixel results, neither of which is done for the GTK+ port.
Alex Christensen
Comment 5 2015-12-09 23:56:43 PST
Comment on attachment 266987 [details] Patch WTF::safeMultiply doesn't seem to be used anywhere. Checked<...> does.
Zan Dobersek
Comment 6 2015-12-10 02:25:17 PST
Comment on attachment 266987 [details] Patch Clearing flags on attachment: 266987 Committed r193898: <http://trac.webkit.org/changeset/193898>
Zan Dobersek
Comment 7 2015-12-10 02:25:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.