Bug 152033 – Web Inspector: Adopt Number.prototype.toLocaleString For All Sizes and Times

• Component: Web Inspector
• Status: RESOLVED FIXED

[Timothy Hatcher]

We can make our number utilities use this to get proper localization for numbers.

[Radar WebKit Bug Importer]

<rdar://problem/23815589>

[Timothy Hatcher]

Support landed in http://trac.webkit.org/changeset/193493.

[Timothy Hatcher]

<rdar://problem/6869032>

[Blaze Burg]

This won't do anything (formatting or locale-specific formatting) until Intl.NumberFormat is implemented.

[Matt Baker]

Created attachment 276496 [details]
[Patch] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 276496 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=276496&action=review

> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:605
> +            let value = typeof obj.value === "number" ? obj.value : obj.description;
> +            return String.standardFormatters.f(value, token);

We should have a test for this given it is a behavior change. For instance, this affects console.log("%.3f", Math.PI).

[Matt Baker]

(In reply to comment #6)
> Comment on attachment 276496 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276496&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:605
> > +            let value = typeof obj.value === "number" ? obj.value : obj.description;
> > +            return String.standardFormatters.f(value, token);
> 
> We should have a test for this given it is a behavior change. For instance,
> this affects console.log("%.3f", Math.PI).

I looked at adding console tests, but wasn't sure how to go about it since message formatting is done at the view level.

[WebKit Commit Bot]

Comment on attachment 276496 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 276496

Committed r199635: <http://trac.webkit.org/changeset/199635>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.