Bug 15203

Summary: [gtk] Don't use FcBool in backend code
Product: WebKit Reporter: Sven Herzberg <sven>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: richard
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: PC   
OS: OS X 10.4   
Attachments:
Description Flags
Proposed Patch
aroben: review+
Proposed Patch v2 aroben: review+

Sven Herzberg
Reported 2007-09-13 09:07:49 PDT
FcBool is only available if the system provides fontconfig. If webkit/gtk should be portable to other platforms (think of Gtk+/MacOS or GTK+/Win) fontconfig won't be available. Patch follows.
Attachments
Proposed Patch (1.10 KB, patch)
2007-09-13 09:12 PDT, Sven Herzberg 		aroben: review+
DetailsFormatted DiffDiff
Proposed Patch v2 (1.13 KB, patch)
2007-09-13 09:42 PDT, Sven Herzberg 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sven Herzberg
Comment 1 2007-09-13 09:12:56 PDT
Created attachment 16278 [details] Proposed Patch
Adam Roben (:aroben)
Comment 2 2007-09-13 09:29:15 PDT
Comment on attachment 16278 [details] Proposed Patch + static bool initialized = false; You don't need to initialize this variable to false (that will happen automatically as a result of it being declared static). Please leave the "Reviewed by NOBODY (OOPS!)." line that prepare-ChangeLog generates for you, as we have pre-commit hooks that prevent anyone from checking in an unreviewed change this way. r=me
Sven Herzberg
Comment 3 2007-09-13 09:42:04 PDT
Created attachment 16279 [details] Proposed Patch v2
Adam Roben (:aroben)
Comment 4 2007-09-13 09:50:44 PDT
Comment on attachment 16279 [details] Proposed Patch v2 r=me. Thanks for the fixes!
Mark Rowe (bdash)
Comment 5 2007-09-14 02:55:18 PDT
Landed in r25561.
Note You need to log in before you can comment on or make changes to this bug.