Bug 152006

Summary:

Unify iOS Frame::setTimersPaused() logic and Frame::{suspend, resume}ActiveDOMObjectsAndAnimations()

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, allan.jensen, ap, beidson, darin, ddkilzer, dino, zoltan

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews115 for mac-yosemite	none

Daniel Bates

Reported 2015-12-08 12:14:34 PST

We have almost identical logic to suspend and resume a web page for iOS and non-iOS ports. We should unify this machinery.

Attachments
Patch (18.41 KB, patch) 2015-12-08 13:33 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-yosemite (1.26 MB, application/zip) 2015-12-08 15:00 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2015-12-08 13:33:28 PST

Created attachment 266933 [details] Patch

Build Bot

Comment 2 2015-12-08 15:00:13 PST

Comment on attachment 266933 [details] Patch Attachment 266933 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/534217 New failing tests: storage/indexeddb/mutating-cursor.html

Build Bot

Comment 3 2015-12-08 15:00:15 PST

Created attachment 266943 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Brady Eidson

Comment 4 2015-12-08 15:19:55 PST

The test failing is storage/indexeddb/mutating-cursor.html It's flaky already, nothing to do with this patch.

Daniel Bates

Comment 5 2015-12-09 18:51:30 PST

Comment on attachment 266933 [details] Patch Clearing flags on attachment: 266933 Committed r193884: <http://trac.webkit.org/changeset/193884>

Daniel Bates

Comment 6 2015-12-09 18:51:34 PST

All reviewed patches have been landed. Closing bug.

Daniel Bates

Comment 7 2015-12-09 19:00:57 PST

<rdar://problem/23834063>

Note You need to log in before you can comment on or make changes to this bug.