Summary: | [Cocoa] ResourceUsageOverlay should query kernel for VM page size. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | WebCore Misc. | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2015-12-05 22:10:31 PST
Created attachment 266726 [details]
Patch
Comment on attachment 266726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266726&action=review > Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:79 > + sysctlbyname("vm.pagesize", &pageSize, &outputSize, nullptr, 0); Could you ASSERT that outputSize still equals sizeof(pageSize) after this call? You might also want to either handle an error or ASSERT that none occurred. I'm imagining a case where we could end up diving by zero later on. Created attachment 266892 [details]
Patch for landing
Comment on attachment 266892 [details] Patch for landing Clearing flags on attachment: 266892 Committed r193757: <http://trac.webkit.org/changeset/193757> All reviewed patches have been landed. Closing bug. |