Bug 151898

Summary:

Modern IDB: Add some more custom exception messages, passing some more tests

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, commit-queue, jsbell

Priority:

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

149117, 150882

Attachments:

Description	Flags
Patch v1	achristensen: review+, achristensen: commit-queue-
Patch for landing	none

Brady Eidson

Reported 2015-12-04 17:23:11 PST

Modern IDB: Add some more custom exception messages, passing some more tests Another batch.

Attachments
Patch v1 (15.63 KB, patch) 2015-12-04 17:24 PST, Brady Eidson	achristensen: review+ achristensen: commit-queue-	Details Formatted Diff Diff
Patch for landing (16.62 KB, patch) 2015-12-04 20:41 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2015-12-04 17:24:10 PST

Created attachment 266689 [details] Patch v1

Alex Christensen

Comment 2 2015-12-04 17:31:03 PST

Comment on attachment 266689 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=266689&action=review r=me except one thing: > LayoutTests/storage/indexeddb/transaction-and-objectstore-calls-expected.txt:163 > -PASS code is DOMException.INVALID_STATE_ERR > -PASS ename is 'InvalidStateError' > -Exception message: Failed to execute 'index' on 'IDBObjectStore': The transaction has finished. > +FAIL code should be 11. Was 0. > +FAIL ename should be InvalidStateError. Was TransactionInactiveError. This is no good. Either intentionally change the test because we are now conforming to a spec that has changed since this was written, or change the code to conform to the spec. Don't change PASS to FAIL in an expectations.

Brady Eidson

Comment 3 2015-12-04 20:40:07 PST

(In reply to comment #2) > Comment on attachment 266689 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266689&action=review > > r=me except one thing: > > > LayoutTests/storage/indexeddb/transaction-and-objectstore-calls-expected.txt:163 > > -PASS code is DOMException.INVALID_STATE_ERR > > -PASS ename is 'InvalidStateError' > > -Exception message: Failed to execute 'index' on 'IDBObjectStore': The transaction has finished. > > +FAIL code should be 11. Was 0. > > +FAIL ename should be InvalidStateError. Was TransactionInactiveError. > > This is no good. Either intentionally change the test because we are now > conforming to a spec that has changed since this was written, or change the > code to conform to the spec. Don't change PASS to FAIL in an expectations. Yup yikes, good call. Thanks.

Brady Eidson

Comment 4 2015-12-04 20:41:30 PST

Created attachment 266700 [details] Patch for landing

WebKit Commit Bot

Comment 5 2015-12-04 21:25:28 PST

Comment on attachment 266700 [details] Patch for landing Clearing flags on attachment: 266700 Committed r193510: <http://trac.webkit.org/changeset/193510>

WebKit Commit Bot

Comment 6 2015-12-04 21:25:31 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.