Summary: | JSON.stringify returns empty when used with performance.timing. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Guilherme <guilhermezz> | ||||||
Component: | JavaScriptCore | Assignee: | Dean Jackson <dino> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, dino, euskadi31, ossy, rniwa, tpessato, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari 9 | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.10 | ||||||||
Attachments: |
|
Description
Guilherme
2015-12-03 11:45:13 PST
I confirm the problem. Safari Version 9.1.1 (11601.6.17) I'm having the same problem. Are there any plans to fix this anytime soon? Really need this. (In reply to comment #2) > I'm having the same problem. > > Are there any plans to fix this anytime soon? Really need this. Yes, because you asked nicely!!! :) (In reply to comment #4) > (In reply to comment #2) > > I'm having the same problem. > > > > Are there any plans to fix this anytime soon? Really need this. > > Yes, because you asked nicely!!! :) Yey, Thank you! :) Created attachment 287347 [details]
Patch
Comment on attachment 287347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287347&action=review > Source/WebCore/bindings/js/JSPerformanceTimingCustom.cpp:46 > + CodeBlock* codeBlock = state.codeBlock(); > + PutPropertySlot slot(object, codeBlock ? codeBlock->isStrictMode() : false); I don't think you need to set the isStrictMode bit here. Just set it to false and remove the code block. Probably also want to use putDirect. Comment on attachment 287347 [details] Patch Attachment 287347 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1968461 New failing tests: http/tests/misc/webtiming-no-origin.html http/tests/misc/webtiming-cross-origin-redirect.php http/tests/misc/webtiming-cross-origin-and-back1.html Created attachment 287354 [details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Committed r205161: <http://trac.webkit.org/changeset/205161> (In reply to comment #10) > Committed r205161: <http://trac.webkit.org/changeset/205161> It broke the !ENABLE(WEB_TIMING) build: ../../Source/WebCore/bindings/js/JSPerformanceTimingCustom.cpp:38:14: error: 'JSPerformanceTiming' has not been declared ../../Source/WebCore/bindings/js/JSPerformanceTimingCustom.cpp: In function 'JSC::JSValue WebCore::toJSON(JSC::ExecState&)': ../../Source/WebCore/bindings/js/JSPerformanceTimingCustom.cpp:40:5: error: 'PerformanceTiming' was not declared in this scope ../../Source/WebCore/bindings/js/JSPerformanceTimingCustom.cpp:40:24: error: 'timing' was not declared in this scope ../../Source/WebCore/bindings/js/JSPerformanceTimingCustom.cpp:40:41: error: 'wrapped' was not declared in this scope Source/WebCore/page/PerformanceTiming.idl is guarded, so JSPerformanceTimingCustom.cpp should be guarded too. |