Bug 151805

Summary:

Web Inspector: -webkit-text-size-adjust should be added to the completion list

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, hi, inspector-bugzilla-changes, mmaxfield, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Screenshot	none

Timothy Hatcher

Reported 2015-12-03 09:10:10 PST

Created attachment 266530 [details] Screenshot We should know about -webkit-text-size-adjust, so we don't show a warning icon for it.

Attachments
Screenshot (56.31 KB, image/png) 2015-12-03 09:10 PST, Timothy Hatcher	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-12-03 09:10:47 PST

<rdar://problem/23743529>

Joseph Pecoraro

Comment 2 2015-12-03 10:45:50 PST

CSS.getSupportedCSSProperties only returns the list of supported properties by the platform you are inspecting. OS X does not support that property, only iOS. So when inspecting a page on OS X this will probably happen, but inspecting on iOS it won't. Should we have a list of fuzzy properties to not warn about no matter if the backend supports it? This would likely include any iOS / well known other vendor properties.

Joseph Pecoraro

Comment 3 2015-12-03 10:50:00 PST

(In reply to comment #2) > CSS.getSupportedCSSProperties only returns the list of supported properties > by the platform you are inspecting. OS X does not support that property, > only iOS. I suppose OS X could support the property and just do nothing for it. "none" and "auto" would both mean the same thing. Myles / Simon what do you think about this, is it a bad idea?

Timothy Hatcher

Comment 4 2015-12-03 11:25:43 PST

Yeah, I was mainly thinking about making the warning part not care about iOS. It already ignores properties with other vendor prefixes.

Myles C. Maxfield

Comment 5 2015-12-03 16:48:25 PST

(In reply to comment #3) > (In reply to comment #2) > > CSS.getSupportedCSSProperties only returns the list of supported properties > > by the platform you are inspecting. OS X does not support that property, > > only iOS. > > I suppose OS X could support the property and just do nothing for it. "none" > and "auto" would both mean the same thing. > > Myles / Simon what do you think about this, is it a bad idea? I think this would be a fine idea.

Timothy Hatcher

Comment 6 2015-12-03 17:27:53 PST

Having it work on Mac conditionally would be helpful too. Then we could enable it for responsive design mode.

Devin Rousso

Comment 7 2017-03-16 14:10:20 PDT

This works as of r214067 <https://trac.webkit.org/changeset/214067>.

Note You need to log in before you can comment on or make changes to this bug.