Bug 15179

Summary: REGRESSION: ASSERTION FAILED: !m_committed while committing form in one window and going back in history in another
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, dev+webkit, eric
Priority: P1 Keywords: HasReduction, InRadar, Regression
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Crash log none

David Kilzer (:ddkilzer)
Reported 2007-09-11 09:38:07 PDT
* SUMMARY Unreproducible (only happened once) assertion failure while browsing using a local debug build of WebKit r25488 with Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10 (8R218). I believe this happened while I was going back in history using Cmd-Left-Arrow. Had a number of windows and tabs open at the time. * CONSOLE ASSERTION FAILED: !m_committed (/path/to/WebKit/WebCore/loader/DocumentLoader.cpp:217 setRequest) Segmentation fault * CRASH LOG Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_INVALID_ADDRESS (0x0001) at 0xbbadbeef Thread 0 Crashed: 0 com.apple.WebCore 0x014951a4 WebCore::DocumentLoader::setRequest(WebCore::ResourceRequest const&) + 236 (DocumentLoader.cpp:217) 1 com.apple.WebCore 0x0149864c WebCore::MainResourceLoader::willSendRequest(WebCore::ResourceRequest&, WebCore::ResourceResponse const&) + 392 (MainResourceLoader.cpp:172) 2 com.apple.WebCore 0x01497ed0 WebCore::MainResourceLoader::loadNow(WebCore::ResourceRequest&) + 332 (MainResourceLoader.cpp:359) 3 com.apple.WebCore 0x01498414 WebCore::MainResourceLoader::load(WebCore::ResourceRequest const&, WebCore::SubstituteData const&) + 272 (MainResourceLoader.cpp:396) 4 com.apple.WebCore 0x01494094 WebCore::DocumentLoader::startLoadingMainResource(unsigned long) + 324 (DocumentLoader.cpp:689) 5 com.apple.WebCore 0x0147ee58 WebCore::FrameLoader::continueLoadAfterWillSubmitForm(WebCore::PolicyAction) + 376 (FrameLoader.cpp:2961) 6 com.apple.WebCore 0x01487144 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool) + 1072 (FrameLoader.cpp:3585) 7 com.apple.WebCore 0x014871ac WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool) + 84 (FrameLoader.cpp:3531) 8 com.apple.WebCore 0x01488754 WebCore::FrameLoader::checkNavigationPolicy(WebCore::ResourceRequest const&, WebCore::DocumentLoader*, WTF::PassRefPtr<WebCore::FormState>, void (*)(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool), void*) + 380 (FrameLoader.cpp:3473) 9 com.apple.WebCore 0x01488b7c WebCore::FrameLoader::load(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::FormState>) + 472 (FrameLoader.cpp:2086) 10 com.apple.WebCore 0x0148e110 WebCore::FrameLoader::loadItem(WebCore::HistoryItem*, WebCore::FrameLoadType) + 976 (FrameLoader.cpp:3980) 11 com.apple.WebCore 0x0148ea10 WebCore::FrameLoader::recursiveGoToItem(WebCore::HistoryItem*, WebCore::HistoryItem*, WebCore::FrameLoadType) + 1264 (FrameLoader.cpp:4143) 12 com.apple.WebCore 0x0148eb4c WebCore::FrameLoader::goToItem(WebCore::HistoryItem*, WebCore::FrameLoadType) + 272 (FrameLoader.cpp:4086) 13 com.apple.WebCore 0x011da6b4 WebCore::Page::goToItem(WebCore::HistoryItem*, WebCore::FrameLoadType) + 120 (Page.cpp:161) 14 com.apple.WebCore 0x011da7a8 WebCore::Page::goBack() + 88 (Page.cpp:140) 15 com.apple.WebKit 0x00385f04 -[WebView goBack] + 80 (WebView.mm:2207) 16 com.apple.WebKit 0x0037ae0c -[WebFrameView _goBack] + 92 17 com.apple.WebKit 0x0037c834 -[WebFrameView keyDown:] + 2960 18 com.apple.AppKit 0x9386ff84 forwardMethod + 92 19 com.apple.AppKit 0x9386ff84 forwardMethod + 92 20 com.apple.AppKit 0x9386ff84 forwardMethod + 92 21 com.apple.AppKit 0x939113f0 -[NSControl keyDown:] + 112 22 com.apple.WebKit 0x003559d8 -[WebHTMLView keyDown:] + 712 (WebHTMLView.mm:3577) 23 com.apple.AppKit 0x937fdfa0 -[NSWindow sendEvent:] + 6424 24 com.apple.Safari 0x000ab334 0x1000 + 697140 25 com.apple.AppKit 0x937a68d4 -[NSApplication sendEvent:] + 4172 26 com.apple.Safari 0x00016444 0x1000 + 87108 27 com.apple.AppKit 0x9379dd10 -[NSApplication run] + 508 28 com.apple.AppKit 0x9388e87c NSApplicationMain + 452 29 com.apple.Safari 0x0000244c 0x1000 + 5196 30 com.apple.Safari 0x0004f1b0 0x1000 + 319920 Thread 1: 0 libSystem.B.dylib 0x9002c3c8 semaphore_wait_signal_trap + 8 1 libSystem.B.dylib 0x90030eac pthread_cond_wait + 480 2 com.apple.WebCore 0x017980bc WebCore::ThreadCondition::wait(WebCore::Mutex&) + 48 (Threading.h:66) 3 com.apple.WebCore 0x01388c18 WebCore::IconDatabase::syncThreadMainLoop() + 832 (IconDatabase.cpp:1328) 4 com.apple.WebCore 0x0138a708 WebCore::IconDatabase::iconDatabaseSyncThread() + 1596 (IconDatabase.cpp:975) 5 com.apple.WebCore 0x0138a760 WebCore::IconDatabase::iconDatabaseSyncThreadStart(void*) + 40 (IconDatabase.cpp:881) 6 libSystem.B.dylib 0x9002bd08 _pthread_body + 96
Attachments
Crash log (23.69 KB, text/plain)
2007-09-11 09:38 PDT, David Kilzer (:ddkilzer) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2007-09-11 09:38:49 PDT
Created attachment 16257 [details] Crash log
David Kilzer (:ddkilzer)
Comment 2 2007-09-11 09:46:34 PDT
<rdar://problem/5474002>
David Kilzer (:ddkilzer)
Comment 3 2007-09-18 09:20:31 PDT
Happened again using a local debug build of WebKit r25545 with Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10 (8R218). No idea how to reproduce it yet. ASSERTION FAILED: !m_committed (/path/to/WebKit/WebCore/loader/DocumentLoader.cpp:217 setRequest) Segmentation fault Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_INVALID_ADDRESS (0x0001) at 0xbbadbeef Thread 0 Crashed: 0 com.apple.WebCore 0x01494d44 WebCore::DocumentLoader::setRequest(WebCore::ResourceRequest const&) + 236 (DocumentLoader.cpp:217) 1 com.apple.WebCore 0x014981ec WebCore::MainResourceLoader::willSendRequest(WebCore::ResourceRequest&, WebCore::ResourceResponse const&) + 392 (MainResourceLoader.cpp:172) 2 com.apple.WebCore 0x01497a70 WebCore::MainResourceLoader::loadNow(WebCore::ResourceRequest&) + 332 (MainResourceLoader.cpp:359) 3 com.apple.WebCore 0x01497fb4 WebCore::MainResourceLoader::load(WebCore::ResourceRequest const&, WebCore::SubstituteData const&) + 272 (MainResourceLoader.cpp:396) 4 com.apple.WebCore 0x01493c34 WebCore::DocumentLoader::startLoadingMainResource(unsigned long) + 324 (DocumentLoader.cpp:689) 5 com.apple.WebCore 0x0147e9f8 WebCore::FrameLoader::continueLoadAfterWillSubmitForm(WebCore::PolicyAction) + 376 (FrameLoader.cpp:2961) 6 com.apple.WebCore 0x01486ce4 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool) + 1072 (FrameLoader.cpp:3585) 7 com.apple.WebCore 0x01486d4c WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool) + 84 (FrameLoader.cpp:3531) 8 com.apple.WebCore 0x014882f4 WebCore::FrameLoader::checkNavigationPolicy(WebCore::ResourceRequest const&, WebCore::DocumentLoader*, WTF::PassRefPtr<WebCore::FormState>, void (*)(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool), void*) + 380 (FrameLoader.cpp:3473) 9 com.apple.WebCore 0x0148871c WebCore::FrameLoader::load(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::FormState>) + 472 (FrameLoader.cpp:2086) 10 com.apple.WebCore 0x0148dcb0 WebCore::FrameLoader::loadItem(WebCore::HistoryItem*, WebCore::FrameLoadType) + 976 (FrameLoader.cpp:3980) 11 com.apple.WebCore 0x0148e5b0 WebCore::FrameLoader::recursiveGoToItem(WebCore::HistoryItem*, WebCore::HistoryItem*, WebCore::FrameLoadType) + 1264 (FrameLoader.cpp:4143) 12 com.apple.WebCore 0x0148e6ec WebCore::FrameLoader::goToItem(WebCore::HistoryItem*, WebCore::FrameLoadType) + 272 (FrameLoader.cpp:4086) 13 com.apple.WebCore 0x011d9df4 WebCore::Page::goToItem(WebCore::HistoryItem*, WebCore::FrameLoadType) + 120 (Page.cpp:161) 14 com.apple.WebCore 0x011d9ee8 WebCore::Page::goBack() + 88 (Page.cpp:140) 15 com.apple.WebKit 0x0038621c -[WebView goBack] + 80 (WebView.mm:2160) 16 com.apple.WebKit 0x0037b8ac -[WebFrameView _goBack] + 92 17 com.apple.WebKit 0x0037d2d4 -[WebFrameView keyDown:] + 2960 18 com.apple.AppKit 0x9386ff84 forwardMethod + 92 19 com.apple.AppKit 0x9386ff84 forwardMethod + 92 20 com.apple.AppKit 0x9386ff84 forwardMethod + 92 21 com.apple.AppKit 0x939113f0 -[NSControl keyDown:] + 112 22 com.apple.WebKit 0x00356438 -[WebHTMLView keyDown:] + 712 (WebHTMLView.mm:3568) 23 com.apple.AppKit 0x937fdfa0 -[NSWindow sendEvent:] + 6424 24 com.apple.Safari 0x000ab334 0x1000 + 697140 25 com.apple.AppKit 0x937a68d4 -[NSApplication sendEvent:] + 4172 26 com.apple.Safari 0x00016444 0x1000 + 87108 27 com.apple.AppKit 0x9379dd10 -[NSApplication run] + 508 28 com.apple.AppKit 0x9388e87c NSApplicationMain + 452 29 com.apple.Safari 0x0000244c 0x1000 + 5196 30 com.apple.Safari 0x0004f1b0 0x1000 + 319920
Matt Lilek
Comment 4 2007-09-26 08:26:23 PDT
I just hit this with r25761. I believe I was going back in history from <http://demoroom.physics.nscu.edu/html/vendor.html> at the time.
Matt Lilek
Comment 5 2007-09-26 08:27:46 PDT
(In reply to comment #4) > I just hit this with r25761. I believe I was going back in history from > <http://demoroom.physics.nscu.edu/html/vendor.html> at the time. > Erm... This page <http://demoroom.physics.ncsu.edu/html/vendor.html> (s/nscu/ncsu).
David Kilzer (:ddkilzer)
Comment 6 2007-09-26 09:00:26 PDT
I hit this assertion about once a week, usually when going back in history. Still haven't figured out how to reproduce it reliably, though.
David Kilzer (:ddkilzer)
Comment 7 2007-09-29 13:36:07 PDT
* STEPS TO REPRODUCE 1. Launch a DEBUG build of WebKit with Safari. 2. Open URL in window #1: http://bugs.webkit.org/query.cgi 3. Deselect all items in the Status multi-select box. 4. Type "the" in the "A Comment ... contains the string" text field. 5. Open URL in window #2: http://lists.macosforge.org/pipermail/webkit-unassigned/2007-September/date.html 6. Scroll down to the bottom of the page in window #2, then click a link on one of the mail messages. 7. Click "Search" in window #1. 8. Click "Back" in window #2. * EXPECTED RESULTS The search should complete in Window #1 and the Back button should complete in Window #2. * ACTUAL RESULTS An assertion failure occurs and WebKit/Safari crashes. * NOTES Can't reproduce any bad behavior in WebKit Nightly release build WebKit-SVN-r25801.dmg. Reproduced with a local debug build of WebKit r25803 with Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10 (8R218).
mitz
Comment 8 2007-10-02 13:32:30 PDT
*** Bug 15346 has been marked as a duplicate of this bug. ***
David Kilzer (:ddkilzer)
Comment 9 2007-12-27 06:34:50 PST
Still seeing this in local debug builds as recent as r28996. I wonder if the assertion is actually correct since nothing bad seems to happen in release builds.
Alexey Proskuryakov
Comment 10 2009-05-20 06:03:48 PDT
David, have you seen this assertion since 2007? Can this bug be closed now perhaps?
David Kilzer (:ddkilzer)
Comment 11 2009-05-20 15:10:07 PDT
I can no longer reproduce this with a Debug build of WebKit r43854. Closing!
Note You need to log in before you can comment on or make changes to this bug.