Summary: | [gtk] FontPlatformData contains more fields than required | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sven Herzberg <sven> | ||||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | richard | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 523.x (Safari 3) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | Linux | ||||||||||||||
Attachments: |
|
Description
Sven Herzberg
2007-09-11 07:32:38 PDT
Created attachment 16250 [details]
0001 - Made setFont() easier
Created attachment 16251 [details]
0002 - Removed m_fontFace
Created attachment 16252 [details]
0003 - Removed m_fontMatrix
Created attachment 16253 [details]
0004 - Removed m_options
This is the last patch for now…
This is the diffstat output: FontDataGdk.cpp | 6 ------ FontPlatformData.h | 11 +---------- FontPlatformDataGdk.cpp | 17 ++++++++--------- 3 files changed, 9 insertions(+), 25 deletions(-) Created attachment 16254 [details]
Final Patch (all in one)
Final patch (included the 4 previous ones plus a changelog entry)
Comment on attachment 16254 [details]
Final Patch (all in one)
Some minor comments:
The local variables inside FontPlatformData::FontPlatformData should lose the m_ prefix, which is used only for members. I think the declarations can be moved to their point of first use too.
Our coding style also requires no space between the function name and it's arguments.
I'll make those minor tweaks when I land this.
|