Bug 15176 – run-launcher overwrites LD_LIBRARY_PATH

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Sven Herzberg]

The run-launcher script contains this line of code which breaks running webkit against libraries that also need to specify LD_LIBRARY_PATH:
$ENV{LD_LIBRARY_PATH} = $productDir;

I'm going to attach a fix for this.

[Sven Herzberg]

Created attachment 16249 [details]
Proposed Patch

[Richard Hult]

And while at it, shouldn't the directory really be $productDir/lib?

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> And while at it, shouldn't the directory really be $productDir/lib?

Please file a separate bug for this, or check with Gtk developers on IRC using irc.freenode.net on the #webkit channel.  The existing script appears to be working, so I'm hesitant to mix that change with this one.

[David Kilzer (:ddkilzer)]

Comment on attachment 16249 [details]
Proposed Patch

Using $ENV{LD_LIBRARY_PATH} without checking to see if it's set will cause a "Use of uninitialized value" warning to be printed in the case where it's not set.  You should do something like:

$ENV{LD_LIBRARY_PATH} = $ENV{LD_LIBRARY_PATH} ? "$productDir:$ENV{LD_LIBRARY_PATH}" : $productDir;

Setting review- flag to fix this issue.

Please set the "review?" flag on patches in the future if you'd like them to be reviewed.  (There is no need to set a email address with the review flag.)

Also, please create a ChangeLog entry with the patch.  (The description you have in your git commit message is great!)

http://webkit.org/coding/contributing.html

Thanks for reporting this bug!

[Sven Herzberg]

Created attachment 16255 [details]
Final Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 16255 [details]
Final Patch

Great!  r=me

[David Kilzer (:ddkilzer)]

$ svn commit WebKitTools/ChangeLog WebKitTools/Scripts/run-launcher 
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/Scripts/run-launcher
Transmitting file data ..
Committed revision 25492.