Bug 151678

Summary:

Refactor the op_add, op_sub, and op_mul snippets to use the SnippetOperand class.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, fpizlo, ggaren, keith_miller, msaboff, saam

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	ggaren: review+

Mark Lam

Reported 2015-11-30 15:29:34 PST

This makes the code slightly more compact and easier to reason about.

Attachments
proposed patch. (26.16 KB, patch) 2015-11-30 15:32 PST, Mark Lam	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2015-11-30 15:32:39 PST

Created attachment 266290 [details] proposed patch.

WebKit Commit Bot

Comment 2 2015-11-30 15:34:12 PST

Attachment 266290 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:41: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:42: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:43: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITSubGenerator.h:41: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITSubGenerator.h:42: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITSubGenerator.h:43: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITAddGenerator.h:41: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITAddGenerator.h:42: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITAddGenerator.h:43: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 9 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 3 2015-11-30 15:34:18 PST

Comment on attachment 266290 [details] proposed patch. r=me

Mark Lam

Comment 4 2015-11-30 16:08:54 PST

Thanks for the review. Landed in r192842: <http://trac.webkit.org/r192842>.

Note You need to log in before you can comment on or make changes to this bug.