Summary: | Modern IDB: After versionchange transactions abort, fire onerror on the original IDBOpenDBRequest | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, alecflett, commit-queue, jsbell | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 149117, 150882 | ||||||||||
Attachments: |
|
Description
Brady Eidson
2015-11-29 14:05:54 PST
Created attachment 266230 [details]
Patch v1
Comment on attachment 266230 [details] Patch v1 Attachment 266230 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/494940 New failing tests: storage/indexeddb/modern/index-1.html storage/indexeddb/modern/versionchange-abort-then-reopen.html storage/indexeddb/modern/index-5.html storage/indexeddb/modern/createobjectstore-basic.html storage/indexeddb/modern/deleteindex-2.html storage/indexeddb/modern/double-abort.html storage/indexeddb/aborted-versionchange-closes.html storage/indexeddb/modern/deleteobjectstore-1.html storage/indexeddb/modern/abort-requests-cancelled.html storage/indexeddb/mozilla/versionchange-abort.html Created attachment 266234 [details]
Archive of layout-test-results from ews112 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
(In reply to comment #2) > Comment on attachment 266230 [details] > Patch v1 > > Attachment 266230 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/494940 > > New failing tests: > storage/indexeddb/modern/index-1.html > storage/indexeddb/modern/versionchange-abort-then-reopen.html > storage/indexeddb/modern/index-5.html > storage/indexeddb/modern/createobjectstore-basic.html > storage/indexeddb/modern/deleteindex-2.html > storage/indexeddb/modern/double-abort.html > storage/indexeddb/aborted-versionchange-closes.html > storage/indexeddb/modern/deleteobjectstore-1.html > storage/indexeddb/modern/abort-requests-cancelled.html > storage/indexeddb/mozilla/versionchange-abort.html Bizarre. Definitely a "didn't see that locally" kind of thing. These are crashed DRTs - ASSERTs. Will take a look tomorrow. (In reply to comment #4) > (In reply to comment #2) > > Comment on attachment 266230 [details] > > Patch v1 > > > > Attachment 266230 [details] did not pass mac-debug-ews (mac): > > Output: http://webkit-queues.webkit.org/results/494940 > > > > New failing tests: > > storage/indexeddb/modern/index-1.html > > storage/indexeddb/modern/versionchange-abort-then-reopen.html > > storage/indexeddb/modern/index-5.html > > storage/indexeddb/modern/createobjectstore-basic.html > > storage/indexeddb/modern/deleteindex-2.html > > storage/indexeddb/modern/double-abort.html > > storage/indexeddb/aborted-versionchange-closes.html > > storage/indexeddb/modern/deleteobjectstore-1.html > > storage/indexeddb/modern/abort-requests-cancelled.html > > storage/indexeddb/mozilla/versionchange-abort.html > > Bizarre. Definitely a "didn't see that locally" kind of thing. > > These are crashed DRTs - ASSERTs. Will take a look tomorrow. Just realized - I have 4 or 5 other patches out for review in IDB code that haven't landed, but they *are* committed all locally. They almost certainly are the cause of this. Will re-run this same patch by EWS after those others have landed. Created attachment 266253 [details]
Patch v1 (re-submitted)
Comment on attachment 266253 [details] Patch v1 (re-submitted) Clearing flags on attachment: 266253 Committed r192813: <http://trac.webkit.org/changeset/192813> All reviewed patches have been landed. Closing bug. |