Bug 151630

Summary: Modern IDB: openCursor() fix resulting in at least 4 more passing tests
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 151627    
Bug Blocks: 149117, 150882    
Attachments:
Description Flags
Patch v1
buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews116 for mac-yosemite
none
Patch v2 none

Description Brady Eidson 2015-11-26 22:39:45 PST
Modern IDB: openCursor() fix resulting in at least 4 more passing tests

Fix will rely on https://bugs.webkit.org/show_bug.cgi?id=151627 so I won't bother posting the patch until it is reviewed/landed
Comment 1 Brady Eidson 2015-11-27 13:25:48 PST
Created attachment 266203 [details]
Patch v1
Comment 2 Brady Eidson 2015-11-27 13:35:11 PST
This will probably introduce failures on some modern tests that are straight up wrong. Looking at it now.
Comment 3 Build Bot 2015-11-27 14:10:38 PST
Comment on attachment 266203 [details]
Patch v1

Attachment 266203 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/485921

New failing tests:
storage/indexeddb/modern/index-cursor-1.html
storage/indexeddb/modern/index-cursor-3.html
storage/indexeddb/modern/deleteindex-2.html
storage/indexeddb/modern/index-4.html
storage/indexeddb/modern/index-cursor-2.html
storage/indexeddb/modern/deleteindex-1.html
Comment 4 Build Bot 2015-11-27 14:10:40 PST
Created attachment 266204 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2015-11-27 14:16:25 PST
Comment on attachment 266203 [details]
Patch v1

Attachment 266203 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/485919

New failing tests:
storage/indexeddb/modern/index-cursor-1.html
storage/indexeddb/modern/index-cursor-3.html
storage/indexeddb/modern/deleteindex-2.html
storage/indexeddb/modern/index-4.html
storage/indexeddb/modern/index-cursor-2.html
storage/indexeddb/modern/deleteindex-1.html
Comment 6 Build Bot 2015-11-27 14:16:27 PST
Created attachment 266205 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Brady Eidson 2015-11-27 21:38:33 PST
Created attachment 266209 [details]
Patch v2
Comment 8 WebKit Commit Bot 2015-11-30 10:21:28 PST
Comment on attachment 266209 [details]
Patch v2

Clearing flags on attachment: 266209

Committed r192800: <http://trac.webkit.org/changeset/192800>
Comment 9 WebKit Commit Bot 2015-11-30 10:21:32 PST
All reviewed patches have been landed.  Closing bug.