Bug 151619

Summary:

[cmake] Add testb3 to the build system

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

JavaScriptCore

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, ggaren, ossy

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

152248

Attachments:

Description	Flags
Patch	none
Patch	none

Description Csaba Osztrogonác 2015-11-26 05:07:57 PST

SSIA

Comment 1 Csaba Osztrogonác 2015-11-26 05:13:34 PST

Created attachment 266178 [details]
Patch

Comment 2 Gyuyoung Kim 2015-11-26 18:55:43 PST

Comment on attachment 266178 [details]
Patch

LGTM.

Comment 3 Csaba Osztrogonác 2015-11-27 04:19:31 PST

(In reply to comment #1)
> Created attachment 266178 [details]
> Patch

Windows build fails with the following error:
testb3.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) void __cdecl WTF::printInternal(class WTF::PrintStream &,char const *)" (__imp_?printInternal@WTF@@YAXAAVPrintStream@1@PBD@Z) referenced in function "public: void __thiscall WTF::PrintStream::print<char [24]>(char const (&)[24])" (??$print@$$BY0BI@D@PrintStream@WTF@@QAEXAAY0BI@$$CBD@Z) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\JavaScriptCore\shell\testb3.vcxproj]
testb3.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) class WTF::FilePrintStream & __cdecl WTF::dataFile(void)" (__imp_?dataFile@WTF@@YAAAVFilePrintStream@1@XZ) referenced in function "void __cdecl WTF::dataLog<char [24]>(char const (&)[24])" (??$dataLog@$$BY0BI@D@WTF@@YAXAAY0BI@$$CBD@Z) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\JavaScriptCore\shell\testb3.vcxproj]
C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\testb3.exe : fatal error LNK1120: 2 unresolved externals [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\JavaScriptCore\shell\testb3.vcxproj]

Windows doesn't support FTL JIT yet, not to mention B3,
so I'm going to disable building testb3 on it.

Comment 4 Csaba Osztrogonác 2015-11-27 04:26:10 PST

Created attachment 266197 [details]
Patch

patch for landing with Windows build fix

Comment 5 WebKit Commit Bot 2015-11-27 06:16:40 PST

Comment on attachment 266197 [details]
Patch

Clearing flags on attachment: 266197

Committed r192781: <http://trac.webkit.org/changeset/192781>

Comment 6 WebKit Commit Bot 2015-11-27 06:16:43 PST

All reviewed patches have been landed.  Closing bug.