Bug 151577

Summary: Web Inspector: Cmd-1 to Cmd-9 shortcuts should select tabs by ordinal
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed Fix none

Blaze Burg
Reported 2015-11-23 17:13:05 PST
This would be cool, and match other tab contexts in browsers.
Attachments
Proposed Fix (2.59 KB, patch)
2015-11-23 20:03 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-11-23 17:13:17 PST
<rdar://problem/23652019>
Blaze Burg
Comment 2 2015-11-23 20:03:20 PST
Created attachment 266108 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2015-11-24 10:22:11 PST
Comment on attachment 266108 [details] Proposed Fix Clearing flags on attachment: 266108 Committed r192764: <http://trac.webkit.org/changeset/192764>
WebKit Commit Bot
Comment 4 2015-11-24 10:22:14 PST
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 5 2015-12-01 11:51:31 PST
Comment on attachment 266108 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=266108&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:1860 > + event.preventDefault(); Is this needed? I think the KeyboardShortcut implicitly prevents defaults by default.
Note You need to log in before you can comment on or make changes to this bug.