Summary: | Add an API for getting the branch identifier from a Git or SVN checkout. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matthew Hanson <matthew_hanson> | ||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, dbates, ddkilzer, lforschler, ossy | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Local Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Matthew Hanson
2015-11-23 13:06:06 PST
Created attachment 266095 [details]
Patch
Need to update my checkout. Resubmitting patch shortly. Comment on attachment 266095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266095&action=review Please don't fix the style on unrelated part of the code base. > Tools/ChangeLog:152 > - > + Please don't change other changelog entries. > Tools/Scripts/VCSUtils.pm:11 > -# notice, this list of conditions and the following disclaimer. > +# notice, this list of conditions and the following disclaimer. unrelated typo fix Created attachment 266142 [details]
Patch
(In reply to comment #3) > Comment on attachment 266095 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266095&action=review > > Please don't fix the style on unrelated part of the code base. > > > Tools/ChangeLog:152 > > - > > + > > Please don't change other changelog entries. Fixed. > > > Tools/Scripts/VCSUtils.pm:11 > > -# notice, this list of conditions and the following disclaimer. > > +# notice, this list of conditions and the following disclaimer. > > unrelated typo fix Fixed. I've turned off the automatic whitespace trimming in my editor. Comment on attachment 266142 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266142&action=review > Tools/Scripts/VCSUtils.pm:88 > + svnIdentifierForPath & missing ? (In reply to comment #6) > Comment on attachment 266142 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266142&action=review > > > Tools/Scripts/VCSUtils.pm:88 > > + svnIdentifierForPath > > & missing ? Indeed. Thank you, Gyuyoung. Created attachment 266282 [details]
Patch
Created attachment 266288 [details]
Patch
The final patch makes svnInfoForPath safe to use with paths that are not the current working directory. Comment on attachment 266288 [details]
Patch
r=me
Sorry this took so long to review!
BTW, there are unit tests for VCSUtils.pm here: Tools/Scripts/webkitperl/VCSUtils_unittest/ For the subroutines that just extract data from command output, it might be nice to write a couple tests with output from actual SVN or git WebKit repository checkouts. Testing the methods that run shell commands would be much more difficult since we don't have a way to mock shell commands to run. Comment on attachment 266288 [details] Patch Clearing flags on attachment: 266288 Committed r206283: <http://trac.webkit.org/changeset/206283> All reviewed patches have been landed. Closing bug. |