Summary: | REGRESSION: Image defined in background-position: top center gets unexpectedly truncated | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gérard Talbot <browserbugs2> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mitz, mrowe | ||||
Priority: | P1 | Keywords: | HasReduction, InRadar, Regression | ||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
URL: | http://www.hixie.ch/tests/adhoc/css/background/12.html | ||||||
Attachments: |
|
Description
Gérard Talbot
2007-09-07 13:55:59 PDT
I searched for a duplicate and did not find any. I don't see this in Safari 3 on Tiger. This might be Windows-specific. I reproduced this in TOT on 10.5. It appears to be an incremental painting issue. Resizing the browser window causes the full image to be displayed. After it has occurred once I needed to empty the browser cache to trigger it again. This a regression? I think it might be. (In reply to comment #6) > This a regression? I think it might be. Probably regressed with the patch that refined background image repaints. I simply ignored the fact that when both <html> and <body> specify backgrounds, the body's doesn't propagate to the root. Created attachment 16226 [details]
Account for the case where the body's background doesn't propagate to the root
Yes, this is a regression from Safari 2.0.4 (419.3) with original WebKit on Mac OS X 10.4.10 (8R218). (In reply to comment #9) > Yes, this is a regression from Safari 2.0.4 (419.3) with original WebKit on Mac > OS X 10.4.10 (8R218). Tested with a local debug build of WebKit r25410 with Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10 (8R218). Comment on attachment 16226 [details]
Account for the case where the body's background doesn't propagate to the root
r=me
Landed in r25487. The pixel tests seem to suggest that fast/repaint/body-background-image.html may have regressed on the newly merged feature branch. The apple is no longer "highlighted" by a lighter square in the "actual" results. The entire page is instead a dim grey. I don't really know how repaint tests work though. Please re-close this bug (after updating the pixel test results) if I have simply misunderstood the test. I don't see any expected results checked into either feature-branch or trunk however. Odd. (In reply to comment #13) > I don't see any expected results checked into either feature-branch or trunk > however. Odd. <http://trac.webkit.org/projects/webkit/browser/trunk/LayoutTests/platform/mac/fast/repaint/body-background-image-expected.png?rev=25487> This is reopened, but the comments don't really seem sure about why it was reopened. Mitz, can you verify that your patch did in fact fix it and that it's passing on trunk at present? Looks fine to me with TOT. |