Bug 151553

Summary: [WTF][EFL] Fix signed overflow build break with gcc >= 5.1
Product: WebKit Reporter: Joonghun Park <jh718.park>
Component: Web Template FrameworkAssignee: Joonghun Park <jh718.park>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, gyuyoung.kim, hs85.jeong, ossy
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Joonghun Park
Reported 2015-11-22 12:12:54 PST
When building with gcc >= 5.1, signed overflow warning occurs as below. ../../Source/WTF/wtf/dtoa/bignum.cc: In member function ‘void WTF::double_conversion::Bignum::AssignDecimalString(WTF::double_conversion::BufferReference<const char>)’: ../../Source/WTF/wtf/dtoa/bignum.cc:105:10: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow] void Bignum::AssignDecimalString(BufferReference<const char> value) { ^ cc1plus: all warnings being treated as errors
Attachments
Patch (1.39 KB, patch)
2015-11-22 12:17 PST, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joonghun Park
Comment 1 2015-11-22 12:17:10 PST
Created attachment 266062 [details] Patch
Hunseop Jeong
Comment 2 2015-11-22 16:23:21 PST
ossy already tried to fix this bug, isn't it? *** This bug has been marked as a duplicate of bug 150797 ***
Joonghun Park
Comment 3 2015-11-22 16:34:30 PST
Yes, it is as you said. If Darin's comment is applied, it seems to be resolved immediately.
Csaba Osztrogonác
Comment 4 2015-11-23 04:12:02 PST
Comment on attachment 266062 [details] Patch Cleared review? from attachment 266062 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.