Bug 151523

Summary: More deviceRGB color cleanup
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2015-11-20 15:55:39 PST
More deviceRBG color cleanup
Attachments
Patch (25.02 KB, patch)
2015-11-20 15:58 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (25.77 KB, patch)
2015-11-20 16:15 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-11-20 15:58:01 PST
Created attachment 266009 [details] Patch
WebKit Commit Bot
Comment 2 2015-11-20 15:59:14 PST
Attachment 266009 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:441: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:502: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2015-11-20 16:00:09 PST
Comment on attachment 266009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266009&action=review > Source/WebCore/ChangeLog:3 > + More deviceRBG color cleanup RBG! > Source/WebCore/ChangeLog:8 > + Replace calls to deviceRGBColorSpaceRef() with sRGBColorSpaceRef(, and use ()
Radar WebKit Bug Importer
Comment 4 2015-11-20 16:06:31 PST
<rdar://problem/23638597>
Simon Fraser (smfr)
Comment 5 2015-11-20 16:15:58 PST
Created attachment 266011 [details] Patch
WebKit Commit Bot
Comment 6 2015-11-20 16:18:42 PST
Attachment 266011 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:441: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:502: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2015-11-20 17:51:54 PST
Comment on attachment 266011 [details] Patch Clearing flags on attachment: 266011 Committed r192712: <http://trac.webkit.org/changeset/192712>
WebKit Commit Bot
Comment 8 2015-11-20 17:51:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.