Bug 151523

Summary: More deviceRGB color cleanup
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Simon Fraser (smfr) 2015-11-20 15:55:39 PST 
More deviceRBG color cleanup
Comment 1 Simon Fraser (smfr) 2015-11-20 15:58:01 PST 
Created attachment 266009 [details]
Patch
Comment 2 WebKit Commit Bot 2015-11-20 15:59:14 PST 
Attachment 266009 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:441:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:502:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2015-11-20 16:00:09 PST 
Comment on attachment 266009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266009&action=review

> Source/WebCore/ChangeLog:3
> +        More deviceRBG color cleanup

RBG!

> Source/WebCore/ChangeLog:8
> +        Replace calls to deviceRGBColorSpaceRef() with sRGBColorSpaceRef(, and use

()
Comment 4 Radar WebKit Bug Importer 2015-11-20 16:06:31 PST 
<rdar://problem/23638597>
Comment 5 Simon Fraser (smfr) 2015-11-20 16:15:58 PST 
Created attachment 266011 [details]
Patch
Comment 6 WebKit Commit Bot 2015-11-20 16:18:42 PST 
Attachment 266011 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:441:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:502:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2015-11-20 17:51:54 PST 
Comment on attachment 266011 [details]
Patch

Clearing flags on attachment: 266011

Committed r192712: <http://trac.webkit.org/changeset/192712>
Comment 8 WebKit Commit Bot 2015-11-20 17:51:58 PST 
All reviewed patches have been landed.  Closing bug.