Bug 151506
| Summary: | [Win] fast/events showModalDialog tests failing due to undefined function | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, ggaren, rniwa |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
Ryan Haddad
[Win] fast/events showModalDialog tests failing due to undefined function
fast/events/beforeunload-showModalDialog.html
fast/events/pagehide-showModalDialog.html
fast/events/unload-showModalDialog.html
Run:
<https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/55210>
Results:
<https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r192684%20(55210)/results.html>
--- /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/events/unload-showModalDialog-expected.txt
+++ /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/events/unload-showModalDialog-actual.txt
@@ -1,5 +1,5 @@
main frame - has 1 onunload handler(s)
-CONSOLE MESSAGE: line 14: Use of window.showModalDialog is not allowed while unloading a page.
+CONSOLE MESSAGE: line 14: TypeError: showModalDialog is not a function. (In 'showModalDialog("resources/modal-dialog.html")', 'showModalDialog' is undefined)
This test verifies that prompts are forbidden when leaving a webpage.
Prompts include alert, confirm, prompt, and showModalDialog.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryan Haddad
Skipped these tests in r192957.
Ahmad Saleem
Following commit stop exposing "stopModalDialog" to web and these tests are now marked to run with webkit-test-runner when showModalDialog is true.
https://github.com/WebKit/WebKit/commit/c4bb4d1af89e1ef5f57ef1b1cf7b65ce62c30ba5
I think these failing tests will not fixed. Hence, I am going to mark this as "RESOLVED WONTFIX", please reopen if my selection is wrong and there is further needed from this bug. Thanks!