Summary: | Fix coding style of Intl code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sukolsak Sakshuwong <sukolsak> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, ggaren, keith_miller, mark.lam, msaboff, saam, sukolsak | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Sukolsak Sakshuwong
2015-11-20 05:18:31 PST
Created attachment 265950 [details]
Patch
Comment on attachment 265950 [details]
Patch
Hmmm, I know Darin said to use "state" instead of "exec" for the ExecState*, but I wonder if we should do that. Using "exec" to mean "ExecState*" is universally practiced in JSC code. Changing to use "state" in just some places would actually make it harder to read.
(In reply to comment #2) > Hmmm, I know Darin said to use "state" instead of "exec" for the ExecState*, > but I wonder if we should do that. Using "exec" to mean "ExecState*" is > universally practiced in JSC code. Changing to use "state" in just some > places would actually make it harder to read. If you look you will see that we are starting to change "exec" to "state" in much new code, at least in WebCore. (In reply to comment #3) > (In reply to comment #2) > > Hmmm, I know Darin said to use "state" instead of "exec" for the ExecState*, > > but I wonder if we should do that. Using "exec" to mean "ExecState*" is > > universally practiced in JSC code. Changing to use "state" in just some > > places would actually make it harder to read. > > If you look you will see that we are starting to change "exec" to "state" in > much new code, at least in WebCore. Sigh ... such a rookie mistake (clicked Save before adding comment) ... (In reply to comment #3) > If you look you will see that we are starting to change "exec" to "state" in > much new code, at least in WebCore. OK. I'm good with this if this is the new direction we're taking. There might be people who don’t agree with me, but I think it’s a good change that we should eventually do everywhere. My vote would be to rename all ExecState to CallFrame. And we have a natural name for the variable: (CallFrame* callFrame) Comment on attachment 265950 [details] Patch Clearing flags on attachment: 265950 Committed r192831: <http://trac.webkit.org/changeset/192831> All reviewed patches have been landed. Closing bug. |