Bug 151487

Summary: [Streams API] teeReadableStream should not directly use stream.getReader()
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2015-11-20 02:46:52 PST
teeReadableStream should not directly use stream.getReader()
Attachments
Patch (1.54 KB, patch)
2015-11-20 02:50 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.90 KB, patch)
2015-12-01 01:17 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-11-20 02:50:03 PST
Created attachment 265947 [details] Patch
Darin Adler
Comment 2 2015-11-30 11:59:26 PST
Comment on attachment 265947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265947&action=review > Source/WebCore/ChangeLog:8 > + No change in behavior. This is not true. The comment below says “may be disrupted by user scripts”, so there is an observable behavior change we could and should test.
youenn fablet
Comment 3 2015-12-01 01:17:55 PST
Created attachment 266342 [details] Patch for landing
youenn fablet
Comment 4 2015-12-01 01:19:59 PST
(In reply to comment #2) > Comment on attachment 265947 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265947&action=review > > > Source/WebCore/ChangeLog:8 > > + No change in behavior. > > This is not true. The comment below says “may be disrupted by user scripts”, > so there is an observable behavior change we could and should test. Right, I added a test to cover non regression.
WebKit Commit Bot
Comment 5 2015-12-01 02:14:17 PST
Comment on attachment 266342 [details] Patch for landing Clearing flags on attachment: 266342 Committed r192877: <http://trac.webkit.org/changeset/192877>
WebKit Commit Bot
Comment 6 2015-12-01 02:14:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.