Bug 151478

Summary:

Perf dashboard's runs API uses more than 128MB of memory

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, dewei_zhu, jond, kling, koivisto, rniwa, timothy

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	none

Description Ryosuke Niwa 2015-11-19 20:59:02 PST

When there are many entires in the JSON, we end up consuming twice as much memory as needed
because we use query_and_fetch_all instead of iteratively processing the result rows.

Comment 1 Ryosuke Niwa 2015-11-19 21:06:33 PST

Created attachment 265938 [details]
Fixes the bug

Comment 2 Andreas Kling 2015-11-20 11:06:35 PST

Comment on attachment 265938 [details]
Fixes the bug

r=me

Comment 3 Ryosuke Niwa 2015-11-20 12:39:36 PST

Comment on attachment 265938 [details]
Fixes the bug

Clearing flags on attachment: 265938

Committed r192691: <http://trac.webkit.org/changeset/192691>

Comment 4 Ryosuke Niwa 2015-11-20 12:39:39 PST

All reviewed patches have been landed.  Closing bug.