Bug 151478

Summary: Perf dashboard's runs API uses more than 128MB of memory
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, jond, kling, koivisto, rniwa, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug none

Ryosuke Niwa
Reported 2015-11-19 20:59:02 PST
When there are many entires in the JSON, we end up consuming twice as much memory as needed because we use query_and_fetch_all instead of iteratively processing the result rows.
Attachments
Fixes the bug (7.64 KB, patch)
2015-11-19 21:06 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-11-19 21:06:33 PST
Created attachment 265938 [details] Fixes the bug
Andreas Kling
Comment 2 2015-11-20 11:06:35 PST
Comment on attachment 265938 [details] Fixes the bug r=me
Ryosuke Niwa
Comment 3 2015-11-20 12:39:36 PST
Comment on attachment 265938 [details] Fixes the bug Clearing flags on attachment: 265938 Committed r192691: <http://trac.webkit.org/changeset/192691>
Ryosuke Niwa
Comment 4 2015-11-20 12:39:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.