Bug 151434
| Summary: | Web Inspector: window.error handlers are not profiled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> |
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Joseph Pecoraro
* SUMMARY
window.error handlers are not profiled
NOTE: window.addEventListener("error") are profiled.
* TEST
<button id="x">Click</button>
<script>
window.x.onclick = function() {
({}).x.x;
};
window.onerror = function() {
alert("test");
}
</script>
* STEPS TO REPRODUCE
1. Inspect test page
2. Start timeline
3. Click button
4. Dismiss alert
5. Stop timeline
=> Scripts Timeline does not show the onerror handler
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/23607385>
Blaze Burg
No idea where this handler is being called. Didn't find any obvious JSC::call sites that were missed.
Joseph Pecoraro
This should be addressed now by Script Profiler.
Joseph Pecoraro
Fixed by Bug 152727.
Source/WebCore/bindings/js/JSErrorHandler.cpp got willCallFunction and didCallFunction inspector instrumentation calls.
*** This bug has been marked as a duplicate of bug 152727 ***