Bug 151421

Summary: Modern IDB: Populate indexes created in object stores that already have records
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch v1
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite
none
Archive of layout-test-results from ews116 for mac-yosemite
none
Patch again none

Brady Eidson
Reported 2015-11-18 16:10:11 PST
Modern IDB: Populate indexes created in object stores that already have records
Attachments
Patch v1 (14.54 KB, patch)
2015-11-18 17:21 PST, Brady Eidson 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-yosemite (726.85 KB, application/zip)
2015-11-18 18:05 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews116 for mac-yosemite (773.14 KB, application/zip)
2015-11-18 18:17 PST, Build Bot 		no flags
Details
Patch again (14.53 KB, patch)
2015-11-18 20:50 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-11-18 17:21:17 PST
Created attachment 265815 [details] Patch v1
Build Bot
Comment 2 2015-11-18 18:05:46 PST
Comment on attachment 265815 [details] Patch v1 Attachment 265815 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/447777 New failing tests: storage/indexeddb/modern/index-4.html
Build Bot
Comment 3 2015-11-18 18:05:50 PST
Created attachment 265818 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 4 2015-11-18 18:17:45 PST
Comment on attachment 265815 [details] Patch v1 Attachment 265815 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/447796 New failing tests: storage/indexeddb/modern/index-4.html
Build Bot
Comment 5 2015-11-18 18:17:50 PST
Created attachment 265820 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Brady Eidson
Comment 6 2015-11-18 18:44:28 PST
Layout test failures are because the index cursors patch hasn't landed yet. Doh!
Brady Eidson
Comment 7 2015-11-18 19:53:25 PST
(In reply to comment #6) > Layout test failures are because the index cursors patch hasn't landed yet. > Doh! The bug/patch in question is https://bugs.webkit.org/show_bug.cgi?id=151278 The failing layout tests here relies on 151278 landing. Will resubmit after CQ finally lands it.
Brady Eidson
Comment 8 2015-11-18 20:50:11 PST
Created attachment 265843 [details] Patch again
WebKit Commit Bot
Comment 9 2015-11-19 00:20:01 PST
Comment on attachment 265843 [details] Patch again Clearing flags on attachment: 265843 Committed r192618: <http://trac.webkit.org/changeset/192618>
WebKit Commit Bot
Comment 10 2015-11-19 00:20:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.