Bug 151357

Summary: [WinCairo][MediaFoundation] Current playback time is not shown.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description peavo 2015-11-17 13:08:53 PST 
We need to implement the currentTime() method.
Comment 1 peavo 2015-11-17 13:23:09 PST 
Created attachment 265704 [details]
Patch
Comment 2 Alex Christensen 2015-11-17 13:26:15 PST 
Comment on attachment 265704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265704&action=review

> Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:1282
> +    return clockTime / 10.0f / 1000.0f / 1000.0f;

Don't we already have a named constant for this?  If not, we should.
Comment 3 peavo 2015-11-17 13:48:36 PST 
Created attachment 265705 [details]
Patch
Comment 4 peavo 2015-11-17 13:49:22 PST 
(In reply to comment #2)
> Comment on attachment 265704 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265704&action=review
> 
> > Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:1282
> > +    return clockTime / 10.0f / 1000.0f / 1000.0f;
> 
> Don't we already have a named constant for this?  If not, we should.

Thanks, good call, updated patch :)
Comment 5 peavo 2015-11-17 13:51:54 PST 
Thanks for the swift review :)
Comment 6 WebKit Commit Bot 2015-11-17 14:41:29 PST 
Comment on attachment 265705 [details]
Patch

Clearing flags on attachment: 265705

Committed r192541: <http://trac.webkit.org/changeset/192541>
Comment 7 WebKit Commit Bot 2015-11-17 14:41:32 PST 
All reviewed patches have been landed.  Closing bug.