Bug 151267
| Summary: | [GTK] Many Layout Tests from imported/blink fail (reftests) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, mcatanzaro, psaavedra, svillar |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Alberto Lopez Perez
There are like 30-40 layout tests from imported/blink failing on the GTK port.
This are reftests.
I have identified at least the following failures:
imported/blink/compositing/squashing/squashing-reflection-disallowed.html [ ImageOnlyFailure ]
imported/blink/compositing/squashing/squash-overflow-hidden-contents.html [ ImageOnlyFailure ]
imported/blink/compositing/squashing/squash-overflow-hidden-scrolltop.html [ ImageOnlyFailure ]
imported/blink/compositing/squashing/subpixel-rounding.html [ ImageOnlyFailure ]
imported/blink/compositing/squashing/transform-squashed-owner.html [ ImageOnlyFailure ]
imported/blink/compositing/will-change/stacking-context-creation.html [ ImageOnlyFailure ]
imported/blink/css3/blending/mix-blend-mode-background-size.html [ ImageOnlyFailure ]
imported/blink/css3/blending/mix-blend-mode-with-opacity-change-js.html [ ImageOnlyFailure ]
imported/blink/css3/blending/mix-blend-mode-with-squashing-layer.html [ ImageOnlyFailure ]
imported/blink/css3/blending/svg-blend-overlapping-elements.html [ ImageOnlyFailure ]
imported/blink/css3/blending/svg-isolation-foreign-no-isolation.html [ ImageOnlyFailure ]
imported/blink/css3/blending/svg-isolation-nested-svg-no-isolation.html [ ImageOnlyFailure ]
imported/blink/editing/selection/deleteFromDocument-crash.html [ ImageOnlyFailure ]
imported/blink/fast/css/tab-size-complex-path.html [ ImageOnlyFailure ]
imported/blink/fast/css/text-overflow-ellipsis-button.html [ ImageOnlyFailure ]
imported/blink/fast/events/click-focus-keydown-no-ring.html [ ImageOnlyFailure ]
imported/blink/fast/gradients/large-horizontal-gradient.html [ ImageOnlyFailure ]
imported/blink/fast/gradients/large-vertical-gradient.html [ ImageOnlyFailure ]
imported/blink/fast/multicol/composited-relpos-2nd-column.html [ ImageOnlyFailure ]
imported/blink/fast/multicol/composited-relpos-simple.html [ ImageOnlyFailure ]
imported/blink/fast/text/international/complex-text-space-in-second-font.html [ ImageOnlyFailure ]
imported/blink/fast/text/international/vertical-positioning-with-combining-marks.html [ ImageOnlyFailure ]
imported/blink/fast/text/tab-renders-as-space.html [ ImageOnlyFailure ]
imported/blink/fast/text/word-spacing-nbsp.html [ ImageOnlyFailure ]
imported/blink/svg/animations/no-attr-radialgradient-spreadmethod.svg [ ImageOnlyFailure ]
imported/blink/svg/canvas/canvas-draw-pattern-size.html [ ImageOnlyFailure ]
imported/blink/svg/custom/feDisplacementMap-invalid-selector.svg [ ImageOnlyFailure ]
imported/blink/svg/filters/big-viewbox.svg [ ImageOnlyFailure ]
imported/blink/svg/filters/feDropShadow-linearrgb-flood-color.svg [ ImageOnlyFailure ]
imported/blink/svg/filters/feOffset-nonuniform-scale.svg [ ImageOnlyFailure ]
imported/blink/svg/filters/filter-huge-clamping.svg [ ImageOnlyFailure ]
imported/blink/webexposed/webkit-focus-ring-exposed-to-quirks-mode.html [ ImageOnlyFailure ]
I will be marking them as failing on the GTK TestExpectations.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
imported/blink/compositing/squashing/squash-overflow-hidden-contents.html and imported/blink/compositing/squashing/subpixel-rounding.html are now passing after we switched on threaded compositor. Updating expectations accordingly.
Michael Catanzaro
(In reply to comment #1)
> imported/blink/compositing/squashing/squash-overflow-hidden-contents.html
> and imported/blink/compositing/squashing/subpixel-rounding.html are now
> passing after we switched on threaded compositor. Updating expectations
> accordingly.
Also imported/blink/compositing/squashing/squash-overflow-hidden-scrolltop.html is passing since enabling threaded compositor.
And the following tests are now passing since r203498 "[Threaded Compositor] Flickering when zooming in/out in maps.google.com," which was clearly not specific to threaded compositor as it fixed lots of tests before threaded compositor was enabled:
imported/blink/compositing/squashing/clip-to-squashed-layer-size.html
imported/blink/compositing/squashing/overflow-scroll-grandchildren.html
imported/blink/compositing/squashing/transform-squashed-owner.html
imported/blink/fast/multicol/composited-relpos-2nd-column.html
imported/blink/fast/multicol/composited-relpos-simple.html
imported/blink/fast/sub-pixel/sub-pixel-transparency-layer.html
Also since r203498, imported/blink/fast/sub-pixel/negative-composited-offset.html usually passes now, but it still fails sometimes. Previously it always failed.
Updating expectations accordingly.
Michael Catanzaro
More fixed tests:
imported/blink/compositing/draws-content/webgl-simple-background.html
imported/blink/compositing/invisible-subtree-compositing-and-preserves-3d.html
imported/blink/compositing/squashing/abspos-under-abspos-overflow-scroll.html
imported/blink/fast/css/fixed-overlaps-absolute-in-clip.html
imported/blink/fast/css/transformed-overflow-hidden-clips-fixed.html
imported/blink/fast/events/click-focus-keydown-no-ring.html
imported/blink/fast/multicol/composited-layer-single-fragment.html
imported/blink/fast/sub-pixel/clip-sub-pixel-composited-layer.html
imported/blink/fast/sub-pixel/negative-composited-offset.html
imported/blink/transforms/inline-transform-and-clipping-roots.html
I missed them at first because they were flaky (already expected to pass). Updating expectations accordingly.
(In reply to comment #2)
> Also since r203498,
> imported/blink/fast/sub-pixel/negative-composited-offset.html usually passes
> now, but it still fails sometimes. Previously it always failed.
It's not true, I must have gotten it mixed up with another test. This test always passes now.
Lastly, imported/blink/webexposed/webkit-focus-ring-exposed-to-quirks-mode.html has not passed in ages. It is currently marked flaky; I'm removing the pass expectation.
Michael Catanzaro
(In reply to comment #3)
> More fixed tests:
>
> imported/blink/transforms/inline-transform-and-clipping-roots.html
This one just crashed with an X window system error, one revision later. Sigh. Changing expectations from [ PASS TIMEOUT ] to [ PASS CRASH ]
Pablo Saavedra
(In reply to Carlos Alberto Lopez Perez from comment #0)
> imported/blink/fast/text/international/vertical-positioning-with-combining-
> marks.html [ ImageOnlyFailure ]
`imported/blink/fast/text/international/vertical-positioning-with-combining-marks.html` is now `Pass` because r254190 fix it.
The https://webkit.org/b/206079 removes the expectation for this test in platform/gtk/TestExpectations for related to this defect.