Bug 151076 – run-api-tests fails to run with public iOS SDK

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Daniel Bates]

Created attachment 265141 [details]
run-api-tests stdio

When I looked at the Apple iOS 9 Simulator Release WK2 (Tests) bot tonight, I noticed that the step run-api-test is green, but has the following error in its stdio output:

[[
perl ./Tools/Scripts/run-api-tests --no-build --release --verbose --ios-simulator
 [....]
xcrun: error: unable to find utility "sim", not a developer tool or in PATH
Failed to build list of tests!--
]]
<https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/1013/steps/run-api-tests/logs/stdio>

The same error can also be seen on the Apple iOS 9 Simulator Release WK1 (Tests) bot: <https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK1%20%28Tests%29/builds/1054/steps/run-api-tests/logs/stdio>.

[Daniel Bates]

Created attachment 265396 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 265396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265396&action=review

> Tools/ChangeLog:8
> +        Use the command line tool simctl as the sim tool was remove from the public iOS 9 SDK.

Typo: should be "was removed"

> Tools/Scripts/run-api-tests:358
> +    if (willUseIOSSimulatorSDKWhenBuilding()) {

It is a little strange that we consult a "when building" function when running the tests.

> Tools/Scripts/webkitdirs.pm:2219
> +sub shutdownSimulatorDevice($)

As a verb, this should be shutDownSimulatorDevice. Also, probably shutDownIOSSimulatorDevice, as webkitdirs is cross-platform.

[Daniel Bates]

(In reply to comment #2)
> Comment on attachment 265396 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265396&action=review
> 
> > Tools/ChangeLog:8
> > +        Use the command line tool simctl as the sim tool was remove from the public iOS 9 SDK.
> 
> Typo: should be "was removed"
> 

Will fix before landing.

> > Tools/Scripts/run-api-tests:358
> > +    if (willUseIOSSimulatorSDKWhenBuilding()) {
> 
> It is a little strange that we consult a "when building" function when
> running the tests.
> 

We should come up with better names for functions willUseIOS{Device, Simulator}SDKWhenBuilding as they are not specific to scripts that build a product. Maybe willUseIOS{Device, Simulator}SDK?

> > Tools/Scripts/webkitdirs.pm:2219
> > +sub shutdownSimulatorDevice($)
> 
> As a verb, this should be shutDownSimulatorDevice. Also, probably
> shutDownIOSSimulatorDevice, as webkitdirs is cross-platform.

Will rename functions {restart, shutdown}SimulatorDevice to {restart, shutDown}IOSSimulatorDevice, respectively, before landing.

[Alexey Proskuryakov]

> Maybe willUseIOS{Device, Simulator}SDK?

This one looks better to me indeed.

[Daniel Bates]

(In reply to comment #4)
> > Maybe willUseIOS{Device, Simulator}SDK?
> 
> This one looks better to me indeed.

Filed bug #151207 to rename the functions webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding().

[Daniel Bates]

Committed r192370: <http://trac.webkit.org/changeset/192370>