Bug 151072

Summary: REGRESSION (r189567): Inline controls on Mac are misplaced
Product: WebKit Reporter: Jon Lee <jonlee>
Component: MediaAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 151067    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jon Lee
Reported 2015-11-09 17:26:54 PST
REGRESSION (r189567): Inline controls on Mac are misplaced
Attachments
Patch (6.14 KB, patch)
2015-11-09 17:55 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (6.08 KB, patch)
2015-11-09 18:08 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (6.04 KB, patch)
2015-11-09 18:20 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-11-09 17:27:21 PST
<rdar://problem/23474515>
Jon Lee
Comment 2 2015-11-09 17:55:31 PST
Created attachment 265130 [details] Patch
Jon Lee
Comment 3 2015-11-09 18:08:37 PST
Created attachment 265135 [details] Patch
Eric Carlson
Comment 4 2015-11-09 18:12:56 PST
Comment on attachment 265135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265135&action=review > LayoutTests/media/controls/fullscreen-button-inline-layout.html:14 > + var currentState = tester.currentState; > + tester.test("We are using the apple idiom") Nit: the local variable isn't necessary.
Jon Lee
Comment 5 2015-11-09 18:20:12 PST
Created attachment 265137 [details] Patch
WebKit Commit Bot
Comment 6 2015-11-10 00:46:39 PST
Comment on attachment 265137 [details] Patch Clearing flags on attachment: 265137 Committed r192205: <http://trac.webkit.org/changeset/192205>
WebKit Commit Bot
Comment 7 2015-11-10 00:46:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.