Bug 151072

Summary: REGRESSION (r189567): Inline controls on Mac are misplaced
Product: WebKit Reporter: Jon Lee <jonlee>
Component: MediaAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 151067    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Jon Lee 2015-11-09 17:26:54 PST
REGRESSION (r189567): Inline controls on Mac are misplaced
Comment 1 Radar WebKit Bug Importer 2015-11-09 17:27:21 PST
<rdar://problem/23474515>
Comment 2 Jon Lee 2015-11-09 17:55:31 PST
Created attachment 265130 [details]
Patch
Comment 3 Jon Lee 2015-11-09 18:08:37 PST
Created attachment 265135 [details]
Patch
Comment 4 Eric Carlson 2015-11-09 18:12:56 PST
Comment on attachment 265135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265135&action=review

> LayoutTests/media/controls/fullscreen-button-inline-layout.html:14
> +                var currentState = tester.currentState;
> +                tester.test("We are using the apple idiom")

Nit: the local variable isn't necessary.
Comment 5 Jon Lee 2015-11-09 18:20:12 PST
Created attachment 265137 [details]
Patch
Comment 6 WebKit Commit Bot 2015-11-10 00:46:39 PST
Comment on attachment 265137 [details]
Patch

Clearing flags on attachment: 265137

Committed r192205: <http://trac.webkit.org/changeset/192205>
Comment 7 WebKit Commit Bot 2015-11-10 00:46:43 PST
All reviewed patches have been landed.  Closing bug.