Bug 151058

Summary: Web Inspector: Reduce synchronous view layouts
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 150993    
Bug Blocks: 146256    
Attachments:
Description Flags
[Patch] Proposed Fix none

Description Matt Baker 2015-11-09 15:51:16 PST
* SUMMARY
Reduce synchronous view layouts. We should be calling View.needsLayout rather than View.updateLayout, unless an up-to-date attribute value for a DOM element is needed.

* NOTES
Once https://bugs.webkit.org/show_bug.cgi?id=150993 is fixed, we should see the majority of view updates occur on the main animation frame. If not, it means that synchronous layouts are flushing the layout tree before the animation frame fires.

Switching to asynchronous layouts should resolve cases where redundant layouts occur (see https://bugs.webkit.org/show_bug.cgi?id=146256).
Comment 1 Radar WebKit Bug Importer 2015-11-09 15:52:00 PST
<rdar://problem/23472397>
Comment 2 Matt Baker 2015-11-18 16:06:19 PST
Created attachment 265798 [details]
[Patch] Proposed Fix
Comment 3 WebKit Commit Bot 2015-11-18 21:44:37 PST
Comment on attachment 265798 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 265798

Committed r192612: <http://trac.webkit.org/changeset/192612>
Comment 4 WebKit Commit Bot 2015-11-18 21:44:41 PST
All reviewed patches have been landed.  Closing bug.