Description
David Kilzer (:ddkilzer)
2015-11-09 09:00:22 PST
Created attachment 265057 [details]
Patch to find build failures; do not review
Created attachment 265060 [details]
Patch to find build failures v2; do not review
Created attachment 265072 [details]
Patch to find build failures v3; do not review
Attachment 265072 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:100: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:102: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:107: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:108: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:109: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:110: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:111: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:112: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:113: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:114: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:119: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:120: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:121: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:125: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:126: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 19 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265088 [details]
Patch to find build failures v4; do not review
Attachment 265088 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:99: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:100: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:106: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:107: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:108: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:109: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:110: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:111: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:112: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:113: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:118: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:119: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:120: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:121: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:125: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 19 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265091 [details]
Patch to find build failures v5; do not review
Attachment 265091 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:100: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:102: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:107: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:108: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:109: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:110: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:111: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:112: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:113: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:114: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:119: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:120: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:121: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:125: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:126: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 19 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265100 [details]
Patch to find build failures v6; do not review
Attachment 265100 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:100: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:102: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:107: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:108: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:109: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:110: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:111: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:112: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:113: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:114: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:119: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:120: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:121: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:125: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:126: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 19 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Looks like iOS and Windows builds are broken. Created attachment 265225 [details]
Patch to find build failures v7; do not review
Attachment 265225 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:102: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:103: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:108: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:109: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:110: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:111: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:112: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:113: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:114: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:115: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:120: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:121: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:125: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:126: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:127: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 19 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265235 [details]
Patch to find build failures v8; do not review
(In reply to comment #13) > Attachment 265225 [details] did not pass style-queue: > > > ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101: enum members > should use InterCaps with an initial capital letter. > [readability/enum_casing] [4] These will stop appearing once the fix for this lands: Bug 104417: [check-webkit-style] False positive (readability/enum_casing) on CF-styled enum members Attachment 265235 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:129: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:130: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:131: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:132: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:133: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:134: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:135: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:136: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:141: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:142: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:143: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:144: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:145: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:146: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:147: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:148: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 19 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265239 [details]
Patch to find build failures v9; do not review
Created attachment 265321 [details]
Patch to find build failures v10; do not review
Created attachment 265324 [details]
Patch to find build failures v11; do not review
Created attachment 265338 [details]
Patch to find build failures v12; do not review
Created attachment 265389 [details]
Patch to find build failures v13; do not review
Created attachment 265402 [details]
Patch to find build failures v14; do not review
Created attachment 265404 [details]
Patch to find build failures v15; do not review
Created attachment 265412 [details]
Patch to find build failures v16; do not review
Created attachment 265420 [details]
Patch to find build failures v17; do not review
Created attachment 265503 [details]
Patch to find build failures v18; do not review
Created attachment 265537 [details]
Patch to find build failures v19; do not review
Created attachment 265538 [details]
Patch to find build failures v20; do not review
Created attachment 265540 [details]
Patch to find build failures v21; do not review
Comment on attachment 265540 [details]
Patch to find build failures v21; do not review
Best way to indicate "do no review" is to not set review? and trigger EWS explicitly instead.
Created attachment 265592 [details]
Patch to find build failures v22
Created attachment 265595 [details]
Patch to find build failures v23
Created attachment 265621 [details]
Patch to find build failures v24
Created attachment 266147 [details]
Patch to find build failures v25
Created attachment 266148 [details]
Patch to find build failures v26
|