Summary: | Modern IDB: Refactor memory objectstore/transaction interation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, alecflett, commit-queue, jsbell | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 149117, 150939 | ||||||
Attachments: |
|
Description
Brady Eidson
2015-11-08 22:09:28 PST
Created attachment 265033 [details]
Patch v1
Comment on attachment 265033 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=265033&action=review > Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp:168 > + ASSERT(!m_orderedKeys || m_orderedKeys->find(keyData) == m_orderedKeys->end()); Why not use contains here instead of find==end? (In reply to comment #2) > Comment on attachment 265033 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265033&action=review > > > Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp:168 > > + ASSERT(!m_orderedKeys || m_orderedKeys->find(keyData) == m_orderedKeys->end()); > > Why not use contains here instead of find==end? m_orderedKeys is a std::set, which apparently doesn't have ::contains() - Only find. :( Comment on attachment 265033 [details] Patch v1 Clearing flags on attachment: 265033 Committed r192163: <http://trac.webkit.org/changeset/192163> All reviewed patches have been landed. Closing bug. |