Summary: | Preview on apple.com/contact with all text selected shows a map | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
Status: | REOPENED --- | ||||||
Severity: | Normal | CC: | bdakin, ryanhaddad | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 150966 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Tim Horton
2015-11-05 16:27:18 PST
Created attachment 264899 [details]
Patch
This change appears to have broken layout test editing/mac/dictionary-lookup/dictionary-lookup-inside-selection.html Run: <https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20%28Tests%29/builds/9696> Results: <https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r192089%20(9696)/results.html> --- /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/editing/mac/dictionary-lookup/dictionary-lookup-inside-selection-expected.txt +++ /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/editing/mac/dictionary-lookup/dictionary-lookup-inside-selection-actual.txt @@ -1,3 +1,3 @@ Some text to not look up. This part is all selected, and should be taken as a unit when looked up. -Lookup string for inside selected text: 'This part is all selected, and should be taken as a unit when looked up.'. +Lookup string for inside selected text: 'unit'. Rolled out in <http://trac.webkit.org/changeset/192090> (In reply to comment #3) > This change appears to have broken layout test > editing/mac/dictionary-lookup/dictionary-lookup-inside-selection.html > > Run: > <https://build.webkit.org/builders/ > Apple%20Yosemite%20Release%20WK2%20%28Tests%29/builds/9696> > Results: > <https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/ > r192089%20(9696)/results.html> > > --- > /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/ > editing/mac/dictionary-lookup/dictionary-lookup-inside-selection-expected.txt > +++ > /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/ > editing/mac/dictionary-lookup/dictionary-lookup-inside-selection-actual.txt > @@ -1,3 +1,3 @@ > Some text to not look up. This part is all selected, and should be taken as > a unit when looked up. > > -Lookup string for inside selected text: 'This part is all selected, and > should be taken as a unit when looked up.'. > +Lookup string for inside selected text: 'unit'. Hmm, I can't reproduce this on El Capitan. |