Bug 150960

Summary: B3 and Air should simplify CFGs
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, sam, sbarati
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150456, 150507    
Attachments:
Description Flags
the patch ggaren: review+

Description Filip Pizlo 2015-11-05 15:11:36 PST
I'll try to do both phases as one using template magic.
Comment 1 Filip Pizlo 2015-11-06 14:54:04 PST
Created attachment 264959 [details]
the patch
Comment 2 WebKit Commit Bot 2015-11-06 14:59:19 PST
Attachment 264959 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/air/AirInst.cpp:41:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2015-11-06 15:24:16 PST
Comment on attachment 264959 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264959&action=review

r=me

> Source/JavaScriptCore/b3/B3BasicBlockUtils.h:68
> +    // We do it this way because to may already be a predecessor of block.

to => there
Comment 4 Filip Pizlo 2015-11-06 15:30:09 PST
(In reply to comment #3)
> Comment on attachment 264959 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264959&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/b3/B3BasicBlockUtils.h:68
> > +    // We do it this way because to may already be a predecessor of block.
> 
> to => there

to => 'to', block => 'block'

The basic block referenced by the variable called 'to' may already be a predecessor of the block referenced by the variable called 'block'.

I'll clarify the comment.
Comment 5 Filip Pizlo 2015-11-06 15:36:20 PST
Landed in https://trac.webkit.org/r192121