Bug 150960

Summary: B3 and Air should simplify CFGs
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150456, 150507    
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2015-11-05 15:11:36 PST
I'll try to do both phases as one using template magic.
Attachments
the patch (34.67 KB, patch)
2015-11-06 14:54 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-11-06 14:54:04 PST
Created attachment 264959 [details] the patch
WebKit Commit Bot
Comment 2 2015-11-06 14:59:19 PST
Attachment 264959 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/air/AirInst.cpp:41: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2015-11-06 15:24:16 PST
Comment on attachment 264959 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=264959&action=review r=me > Source/JavaScriptCore/b3/B3BasicBlockUtils.h:68 > + // We do it this way because to may already be a predecessor of block. to => there
Filip Pizlo
Comment 4 2015-11-06 15:30:09 PST
(In reply to comment #3) > Comment on attachment 264959 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264959&action=review > > r=me > > > Source/JavaScriptCore/b3/B3BasicBlockUtils.h:68 > > + // We do it this way because to may already be a predecessor of block. > > to => there to => 'to', block => 'block' The basic block referenced by the variable called 'to' may already be a predecessor of the block referenced by the variable called 'block'. I'll clarify the comment.
Filip Pizlo
Comment 5 2015-11-06 15:36:20 PST
Landed in https://trac.webkit.org/r192121
Note You need to log in before you can comment on or make changes to this bug.