Summary: | Layout Test accessibility/win/linked-elements.html is crashing on win debug | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, bfulgham, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=150670 | ||||||
Attachments: |
|
Description
Ryan Haddad
2015-11-05 14:09:23 PST
TestExpectations updated in <https://trac.webkit.org/r192075> Mario this looks like fallout from a recent GTK change. are you able to take a look? (In reply to comment #3) > Mario this looks like fallout from a recent GTK change. are you able to take > a look? I'll take a look to it today, yes Created attachment 264933 [details]
Patch proposal
I was trying all sort of things to try to reproduce a similar crash in the GTK+ port but I couldn't so I proposing an speculative fix instead.
As I understand it, the problem is that now I moved those ASSERTs from AccessibilityNodeObject down to AccessibilityRenderObject, we are hitting those checks way more often for objects with an associated renderer since AccessibilityNodeObject::textUnderElement is not executed that often in this case.
So, the checks will probably need to be more precise to avoid being too paranoid, as for instance we don't need to worry about having an stable subtree when we are either going through a RenderText object or not in 'IncludeAllChildren' mode.
Looking at the backtrace, I can see that WebCore::AccessibilityRenderObject::nameForMSAA() calls textUnderElement() with the default mode, so I understand the attached patch should get rid of the crash in Win Debug bots.
Hope this helps
Committed r192103: <http://trac.webkit.org/changeset/192103> I am rolling this out with https://trac.webkit.org/changeset/216825/webkit. Should accessibility/win/linked-elements.html hit this assertion, we need to address it properly. |