Bug 150929

Summary: generate-js-builtins.js should support @internal annotation
Product: WebKit Reporter: youenn fablet <youennf>
Component: Tools / TestsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, benjamin, calvaris, commit-queue, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2015-11-05 05:24:19 PST
@internals allows to distinguish files containing JS built-in functions implementing public APIs, hence tied to a constructor/prototype from internal JS functions, stored within private slots of JSGlobalObject.
Attachments
Patch (10.93 KB, patch)
2015-11-05 06:02 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-11-05 06:02:40 PST
Created attachment 264859 [details] Patch
WebKit Commit Bot
Comment 2 2015-11-05 06:04:54 PST
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
youenn fablet
Comment 3 2015-11-05 06:08:48 PST
(In reply to comment #1) > Created attachment 264859 [details] > Patch This patch only addresses XXBuiltinsFunctions boilerplate classes. We should also remove XXBuiltinsWrapper::exportNames for non-@internal built-ins. This might be better done as a follow-up patch once bug 150482 is resolved.
Blaze Burg
Comment 4 2015-11-06 11:01:11 PST
Comment on attachment 264859 [details] Patch Nice!
WebKit Commit Bot
Comment 5 2015-11-08 03:40:32 PST
Comment on attachment 264859 [details] Patch Clearing flags on attachment: 264859 Committed r192142: <http://trac.webkit.org/changeset/192142>
WebKit Commit Bot
Comment 6 2015-11-08 03:40:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.