Bug 150921

Summary:

Web Inspector: Clean up InjectedScript uses

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

Other

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2015-11-04 20:15:16 PST

* SUMMARY Clean up InjectedScript use - InjectedScripts can be passed as references instead of copied - Some dead InjectedScriptModule code cascades to find more dead code

Attachments
[PATCH] Proposed Fix (13.89 KB, patch) 2015-11-04 20:16 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2015-11-04 20:16:38 PST

Created attachment 264839 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 2 2015-11-05 11:32:29 PST

Comment on attachment 264839 [details] [PATCH] Proposed Fix Clearing flags on attachment: 264839 Committed r192064: <http://trac.webkit.org/changeset/192064>

WebKit Commit Bot

Comment 3 2015-11-05 11:32:33 PST

All reviewed patches have been landed. Closing bug.

Blaze Burg

Comment 4 2015-11-05 11:34:42 PST

(In reply to comment #0) > * SUMMARY > Clean up InjectedScript use > > - InjectedScripts can be passed as references instead of copied > - Some dead InjectedScriptModule code cascades to find more dead code You should have included these points in the ChangeLog.

Note You need to log in before you can comment on or make changes to this bug.