Bug 15087

Summary: REGRESSION: crashes in ResourceHandle::client() on a secondary thread
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: timothy
Priority: P1 Keywords: InRadar, Regression
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
crash log none

Alexey Proskuryakov
Reported 2007-08-26 22:05:33 PDT
WebKit nightlies sometimes crash for me in ResourceHandle::client(). The crash isn't reliably reproducible, but the stack trace immediately shows what the problem is - NSURLConnection calls its delegate on a secondary thread. So, this seems to be an NSURLConnection bug. However, it didn't cause crashes (that often?) for us before, and it can be worked around by forwarding delegate methods to the main thread, so it IMO makes sense to track it in both Radar and Bugzilla. Perhaps a null check would be an adequate fix, too. Thread 1 Crashed: 0 com.apple.WebCore 0x01414850 WebCore::ResourceHandle::client() const + 0 1 com.apple.Foundation 0x92c37d70 -[NSURLConnection(NSURLConnectionInternal) _didFinishReturnCachedResponse:] + 524 2 com.apple.Foundation 0x92c0f01c -[NSConnectionHTTPURLProtocol attemptRetryAfter3xxResponse] + 540 3 com.apple.Foundation 0x92d2235c -[NSConnectionHTTPURLProtocol performHTTPHeaderRead] + 696 4 com.apple.Foundation 0x92c0e844 readStreamCallback2 + 592 5 com.apple.CoreFoundation 0x9082af3c _CFStreamSignalEventSynch + 332 6 com.apple.CoreFoundation 0x907de4fc __CFRunLoopDoSources0 + 384
Attachments
crash log (19.87 KB, text/plain)
2007-08-26 22:29 PDT, Alexey Proskuryakov 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2007-08-26 22:29:40 PDT
Created attachment 16128 [details] crash log
Mark Rowe (bdash)
Comment 2 2007-08-26 23:19:48 PDT
<rdar://problem/5439200>
David Kilzer (:ddkilzer)
Comment 3 2007-08-26 23:36:54 PDT
Related to Bug 14935?
Matt Lilek
Comment 4 2007-08-29 17:34:54 PDT
Related to/possible dupe of bug 15009?
Alexey Proskuryakov
Comment 5 2007-09-27 21:27:47 PDT
I haven't seen this crash for a while, but it used to be very rare anyway... Perhaps a fix similar to what was done in bug 15009 is the way to go.
Timothy Hatcher
Comment 6 2007-09-27 23:06:46 PDT
I think this is the same crash as bug 15009. This one is just missing the -[WebCoreResourceHandleAsDelegate connection:willCacheResponse:] frame.
Alexey Proskuryakov
Comment 7 2007-09-28 05:33:04 PDT
Ah, indeed. Marking as a duplicate. *** This bug has been marked as a duplicate of 15009 ***
Note You need to log in before you can comment on or make changes to this bug.