Summary: | [Win] Minibrowser unable to use WebInspector (CRASH) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Web Inspector | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bburg, bfulgham, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brent Fulgham
2015-11-02 11:26:52 PST
This is emitted by InjectedScriptManager::injectedScriptFor normally when InjectedScriptSource.js has a parse error. Here is one possible issue: JavaScriptCore's DerivedSource.make / CMakeLists.txt attempts to minify the InjectedScriptSource and in the process injects the sourceURL comment that would have been stripped: COMMAND echo "//# sourceURL=__WebInspectorInjectedScript__" > ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InjectedScriptSource.min.js Perhaps that is not doing what we expect on Windows? Did Windows just move to CMake? (In reply to comment #2) > This is emitted by InjectedScriptManager::injectedScriptFor normally when > InjectedScriptSource.js has a parse error. > > Here is one possible issue: > > JavaScriptCore's DerivedSource.make / CMakeLists.txt attempts to minify the > InjectedScriptSource and in the process injects the sourceURL comment that > would have been stripped: > > COMMAND echo "//# sourceURL=__WebInspectorInjectedScript__" > > ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InjectedScriptSource.min.js > > Perhaps that is not doing what we expect on Windows? Did Windows just move > to CMake? Yes it did! That may very well be the problem. It looks like this problem was introduced right around the time we switched Windows over to CMake. It looks like this command: COMMAND echo "//# sourceURL=__WebInspectorInjectedScript__" ... is inserting quotes into the JS file, which is causing a parse error. Created attachment 264637 [details]
Patch
Comment on attachment 264637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264637&action=review > Source/JavaScriptCore/CMakeLists.txt:1277 > - COMMAND echo "//# sourceURL=__WebInspectorInjectedScript__" > ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InjectedScriptSource.min.js > + COMMAND ${CMAKE_COMMAND} -E echo "//# sourceURL=__WebInspectorInjectedScript__" > ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InjectedScriptSource.min.js We should therefore do the same to WebCore: COMMAND echo "//# sourceURL=__WebInspectorCommandLineAPIModuleSource__" > ${DERIVED_SOURCES_WEBCORE_DIR}/CommandLineAPIModuleSource.min.js Committed r191917: <http://trac.webkit.org/changeset/191917> |