Bug 150772

Summary:

[GLIB] Remove support for GSocket main loop sources from GMainLoopSource

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Web Template Framework

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

zan

Priority:

Keywords:

Gtk

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

150771

Bug Blocks:

Attachments:

Description	Flags
Patch	zan: review+

Description Carlos Garcia Campos 2015-11-01 03:42:31 PST

It complicated the code just to make generic what is only used in one place.

Comment 1 Carlos Garcia Campos 2015-11-01 03:46:45 PST

Created attachment 264512 [details]
Patch

Comment 2 Zan Dobersek 2015-11-01 22:20:50 PST

Comment on attachment 264512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264512&action=review

> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:33
> +#include <glib.h>
> +#include <wtf/Forward.h>
> +#include <wtf/Noncopyable.h>
> +#include <wtf/RunLoop.h>
> +#include <wtf/glib/GRefPtr.h>

Also include <functional>, for std::function<>.

> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:40
> +    WTF_MAKE_NONCOPYABLE(GSocketMonitor); WTF_MAKE_FAST_ALLOCATED;

No need for WTF_MAKE_FAST_ALLOCATED -- `new GSocketMonitor` is never called anyway.

> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:45
> +    void start(GSocket*, GIOCondition, RunLoop&, std::function<gboolean (GIOCondition)>);

Take in an rvalue reference to std::function<>. It doesn't change much in this case, but it's a good habit.

Comment 3 Carlos Garcia Campos 2015-11-02 01:34:28 PST

Committed r191881: <http://trac.webkit.org/changeset/191881>