Bug 150772 – [GLIB] Remove support for GSocket main loop sources from GMainLoopSource

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

It complicated the code just to make generic what is only used in one place.

[Carlos Garcia Campos]

Created attachment 264512 [details]
Patch

[Zan Dobersek]

Comment on attachment 264512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264512&action=review

> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:33
> +#include <glib.h>
> +#include <wtf/Forward.h>
> +#include <wtf/Noncopyable.h>
> +#include <wtf/RunLoop.h>
> +#include <wtf/glib/GRefPtr.h>

Also include <functional>, for std::function<>.

> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:40
> +    WTF_MAKE_NONCOPYABLE(GSocketMonitor); WTF_MAKE_FAST_ALLOCATED;

No need for WTF_MAKE_FAST_ALLOCATED -- `new GSocketMonitor` is never called anyway.

> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:45
> +    void start(GSocket*, GIOCondition, RunLoop&, std::function<gboolean (GIOCondition)>);

Take in an rvalue reference to std::function<>. It doesn't change much in this case, but it's a good habit.

[Carlos Garcia Campos]

Committed r191881: <http://trac.webkit.org/changeset/191881>