Bug 150746

Summary: Air should eliminate dead code
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150456    
Attachments:
Description Flags
the patch ggaren: review+

Description Filip Pizlo 2015-10-30 18:38:39 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-10-30 18:43:59 PDT 
Created attachment 264456 [details]
the patch
Comment 2 WebKit Commit Bot 2015-10-30 18:45:53 PDT 
Attachment 264456 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/air/AirEliminateDeadCode.cpp:83:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/b3/air/AirEliminateDeadCode.cpp:91:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/b3/air/AirEliminateDeadCode.cpp:100:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2015-10-31 10:10:53 PDT 
Comment on attachment 264456 [details]
the patch

r=me
Comment 4 Geoffrey Garen 2015-10-31 10:12:51 PDT 
Comment on attachment 264456 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264456&action=review

> Source/JavaScriptCore/b3/air/AirEliminateDeadCode.h:36
> +// This allocates StackSlots to places on the stack. It first allocates the pinned ones in index
> +// order and then it allocates the rest using first fit.

Comment is wrong.
Comment 5 Filip Pizlo 2015-10-31 11:07:57 PDT 
(In reply to comment #4)
> Comment on attachment 264456 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264456&action=review
> 
> > Source/JavaScriptCore/b3/air/AirEliminateDeadCode.h:36
> > +// This allocates StackSlots to places on the stack. It first allocates the pinned ones in index
> > +// order and then it allocates the rest using first fit.
> 
> Comment is wrong.

Ooops!
Comment 6 Filip Pizlo 2015-10-31 16:15:42 PDT 
Landed in http://trac.webkit.org/changeset/191846